#5649 closed Bug (fixed)
Image dialog too wide when many styles are set
| Reported by: | Wiktor Walc | Owned by: | Tobiasz Cudnik |
|---|---|---|---|
| Priority: | Normal | Milestone: | CKEditor 3.4.1 |
| Component: | General | Version: | 3.1 |
| Keywords: | Oracle IE | Cc: | senthil.kumaran@… |
Description
After setting various properties, like border, hspace, vspace etc. and switching to the advanced tab in IE7, the dialog expands too much (see screenshot).
Confirmed in IE6 and IE7.
Attachments (5)
Change History (18)
Changed 15 years ago by
| Attachment: | ckeditor_ie7_image_dialog_advanced_properties_r5444.png added |
|---|
comment:1 Changed 15 years ago by
| Owner: | set to brooks |
|---|---|
| Status: | new → assigned |
Changed 15 years ago by
| Attachment: | 5649.patch added |
|---|
comment:2 Changed 15 years ago by
| Keywords: | review? added |
|---|
comment:3 Changed 15 years ago by
| Keywords: | Review- added; review? removed |
|---|
The idea is ok, while we must limit the fix to only affected browsers, and check whether some undesired 'onchange' event is get triggered by that, besides, DOM changes should be handled by 'element::setCustomData'.
comment:4 Changed 15 years ago by
| Milestone: | CKEditor 3.4 → CKEditor 3.5 |
|---|
comment:5 Changed 15 years ago by
| Owner: | changed from brooks to Tobiasz Cudnik |
|---|---|
| Status: | review_failed → assigned |
I'm taking this one over Brooks.
Changed 15 years ago by
| Attachment: | 5649_2.patch added |
|---|
comment:6 Changed 15 years ago by
| Status: | assigned → review |
|---|
It doesn't trigger any onChange events as there is no dialog API usage.
comment:7 Changed 15 years ago by
| Keywords: | Confirmed removed |
|---|---|
| Status: | review → review_passed |
comment:8 Changed 15 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | review_passed → closed |
Fixed with [5844].
comment:9 Changed 15 years ago by
I am still seeing this problem in the nightly build, please test it using the attached sample file. In this sample file, double click on the "CKEditor" link(Editor Area). This will open up the link dialog and select the advanced tab and see the issue(screen shot is attached).
Changed 15 years ago by
| Attachment: | replacebycode.html added |
|---|
C:\Documents and Settings\SKumaran\Desktop\ckeditor_3.4\ckeditor\_samples
Changed 15 years ago by
| Attachment: | dialog issue.PNG added |
|---|
comment:10 Changed 15 years ago by
| Cc: | senthil.kumaran@… added |
|---|---|
| Keywords: | Oracle added |
comment:12 Changed 15 years ago by
| Keywords: | IE removed |
|---|
where,after try much times to fix it with only CSS rules change, I failed. so comes this heavyweight workaround.