Wrong button label apostrophe escaping

[Frank]

• Descriptive summary : Apostrophes in button labels are replaced by "undefined" instead of empty string

• Steps to reproduce : Found the bug by code-reading. I guess the effect of the bug should be as follows: Define a button with a label containing an apostrophe ("Bill's Button"). Open CKEditor with such a button in Firefox (version >= 10900). Hover over the button. The status bar reads: "void('Billundefineds Button')".

• Browser name and OS : Firefox (version >= 10900).

• Code Patch:

Replace '+' by ',' in button's plugin.js, line 137: svn\CKEditor\trunk\_source\plugins\button\plugin.js (revision 5259):

@@ -134,7 +134,7 @@

'<span class="cke_button">', '<a id="', id, '"' +

' class="', classes, '"',

env.gecko && env.version >= 10900 && !env.hc ? : '" href="javascript:void(\+ ( this.title + env.gecko && env.version >= 10900 && !env.hc ? : '" href="javascript:void(\+ ( this.title

).replace( "'"+ )+ '\')"',

).replace( "'", )+ '\')"',

' title="', this.title, '"' + ' tabindex="-1"' + ' hidefocus="true"' +

[Sa'ar Zac Elias]

Thanks @Jangaroo.

[Sa'ar Zac Elias]

Fixed with [5702].