Opened 15 years ago
Closed 14 years ago
#5651 closed Bug (fixed)
Wrong button label apostrophe escaping
Reported by: | Frank | Owned by: | Sa'ar Zac Elias |
---|---|---|---|
Priority: | Normal | Milestone: | CKEditor 3.4 |
Component: | UI : Dialogs | Version: | |
Keywords: | Confirmed Review+ | Cc: |
Description
- Descriptive summary : Apostrophes in button labels are replaced by "undefined" instead of empty string
- Steps to reproduce : Found the bug by code-reading. I guess the effect of the bug should be as follows: Define a button with a label containing an apostrophe ("Bill's Button"). Open CKEditor with such a button in Firefox (version >= 10900). Hover over the button. The status bar reads: "void('Billundefineds Button')".
- Browser name and OS : Firefox (version >= 10900).
- Code Patch:
Replace '+' by ',' in button's plugin.js, line 137: svn\CKEditor\trunk\_source\plugins\button\plugin.js (revision 5259):
@@ -134,7 +134,7 @@
'<span class="cke_button">', '<a id="', id, '"' +
' class="', classes, '"',
).replace( "'"+ )+ '\')"', |
).replace( "'", )+ '\')"', |
' title="', this.title, '"' + ' tabindex="-1"' + ' hidefocus="true"' +
Attachments (1)
Change History (5)
comment:1 Changed 14 years ago by
Milestone: | → CKEditor 3.4 |
---|
Changed 14 years ago by
Attachment: | 5651.patch added |
---|
comment:2 Changed 14 years ago by
Keywords: | Confirmed Review? added |
---|---|
Owner: | set to Sa'ar Zac Elias |
Status: | new → assigned |
comment:3 Changed 14 years ago by
Component: | General → UI : Dialogs |
---|---|
Keywords: | Review+ added; Review? removed |
Thanks @Jangaroo.