Opened 7 years ago

Closed 7 years ago

#5755 closed New Feature (fixed)

Configuration option for dialog buttons following OS guidelines.

Reported by: Joe Kavanagh Owned by: Sa'ar Zac Elias
Priority: Normal Milestone: CKEditor 3.5
Component: UI : Dialogs Version: 3.3
Keywords: IBM Cc: Damian, satya_minnekanti@…

Description

When on a MAC the dialog buttons are reversed to match the OS. Can a configuration property be provided to enable/disable this feature?

Original feature ticket

Attachments (2)

5755.patch (2.3 KB) - added by Sa'ar Zac Elias 7 years ago.
5755_2.patch (2.3 KB) - added by Sa'ar Zac Elias 7 years ago.

Download all attachments as: .zip

Change History (12)

comment:1 Changed 7 years ago by Satya Minnekanti

Cc: satya_minnekanti@… added

comment:2 Changed 7 years ago by Frederico Caldeira Knabben

Keywords: Confirmed added

Yeah, we could have a new "dialog_buttonsOrder" setting, with possible values: "OS" (default), "ltr" or "rtl".

comment:3 Changed 7 years ago by Frederico Caldeira Knabben

Milestone: CKEditor 3.x

Milestone CKEditor 3.x deleted

comment:4 Changed 7 years ago by Damian

Can we add this to 3.5?

comment:5 in reply to:  4 Changed 7 years ago by Frederico Caldeira Knabben

Milestone: CKEditor 3.5
Version: SVN (CKEditor) - OLD3.3

Replying to damo:

Can we add this to 3.5?

Should not be a big issue. I'm targeting it for now, for investigation.

comment:6 Changed 7 years ago by Sa'ar Zac Elias

Owner: set to Sa'ar Zac Elias
Status: confirmedassigned

Changed 7 years ago by Sa'ar Zac Elias

Attachment: 5755.patch added

comment:7 Changed 7 years ago by Sa'ar Zac Elias

Status: assignedreview

Changed 7 years ago by Sa'ar Zac Elias

Attachment: 5755_2.patch added

comment:8 Changed 7 years ago by Sa'ar Zac Elias

The buttons are now in reverse order by default for RTL.

comment:9 Changed 7 years ago by Garry Yao

Status: reviewreview_passed

My mistake Saare, R+ for the first patch instead of the second.

comment:10 Changed 7 years ago by Sa'ar Zac Elias

Resolution: fixed
Status: review_passedclosed

Fixed with [5914].

Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy