Remove format breaks table show border

[Garry Yao]

Reproducing Procedures

1. Open any of the sample page, insert a default table with no border width;
2. Select All content then click remove format button;
   • Actual Result: The border line of the table is removed.

[Alfonso Martínez de Lizarrondo]

I don't think that the filter is a good solution here because it will make any other property remain in the table instead of applying the removal of format.

[Alfonso Martínez de Lizarrondo]

If the "border" is included in config.removeFormatAttributes then the patch has no effect.

[Sa'ar Zac Elias]

Nice catch.

[Frederico Caldeira Knabben]

The proposed patch is a simple and good fix for this ticket.

But, we could make things a bit more flexible. What about having the removeformat plugin firing an event for each element that is cleaned up, so it can be listened by other plugins and eventually fix things?

We may just check the performance impact of it, but it's worth trying.

Feel free to ask for review again if you feel this approach is not good.

[Alfonso Martínez de Lizarrondo]

My idea about the clean up would be to fire a single event after the command has executed, so in the showborders plugin just has to do a getElementsByTagName("table") to find the tables and check them.

[Frederico Caldeira Knabben]

That's a good option, in case the performance impact of the "per element" approach will be noticeable.

[Sa'ar Zac Elias]

The performance impact is barley noticable according to my tests.

[Sa'ar Zac Elias]

Fixed with [5727].

[Frederico Caldeira Knabben]

I'm still able to reproduce this issue on trunk.

[Frederico Caldeira Knabben]

In fact, it was not only a matter of leaving the border field blank, but setting it to 0 instead.

[Sa'ar Zac Elias]

Fixed with [5770].