Opened 7 years ago

Closed 7 years ago

#5839 closed Bug (fixed)

"Insert row after" removes/moves the ids of the elements from the clicked row.

Reported by: Florin Cazacu Owned by: Martin
Priority: Normal Milestone: CKEditor 3.4.1
Component: General Version: 3.3.1
Keywords: Cc:

Description (last modified by Frederico Caldeira Knabben)

When I use in a table the "Insert row after" command the ids of the elements from the clicked row are messed up in two ways:

  1. The ids from table cells or the clicked table row are moved in the new row.
  2. The ids of other elements (I used <input type="text") are removed.

How to reproduce (This is reproduced in FF 3.6.3 and IE 8):

  1. Insert this html in ckeditor:
<table border="1" cellpadding="1" cellspacing="1" style="width: 200px;">
	<tbody>
		<tr id="r1">
			<td id="c1">
				<input type="text" id="i1"/></td>
			<td id="c2">
				<input type="text" id="i2"/></td>
		</tr>
	</tbody>
</table>
  1. Click the only row and insert row after.
  1. Check the source to see that the ids were removed or moved.

Attachments (1)

5839.patch (795 bytes) - added by Martin 7 years ago.
Patch

Download all attachments as: .zip

Change History (8)

comment:1 Changed 7 years ago by Frederico Caldeira Knabben

Description: modified (diff)

comment:2 Changed 7 years ago by Frederico Caldeira Knabben

Keywords: Confirmed added

comment:3 Changed 7 years ago by Martin

Owner: set to Martin
Status: confirmedassigned

Changed 7 years ago by Martin

Attachment: 5839.patch added

Patch

comment:4 Changed 7 years ago by Martin

Status: assignedreview

comment:5 Changed 7 years ago by Tobiasz Cudnik

Status: reviewreview_passed

Please add space in IF statement on L151 when committing, like this:

if (

comment:6 Changed 7 years ago by Frederico Caldeira Knabben

Milestone: CKEditor 3.4.1

comment:7 Changed 7 years ago by Frederico Caldeira Knabben

Resolution: fixed
Status: review_passedclosed

Fixed with [5884].

Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy