Opened 9 years ago

Closed 9 years ago

#5890 closed Bug (fixed)

Table column resize not working for IE7

Reported by: Lynne Kues Owned by: Frederico Caldeira Knabben
Priority: Normal Milestone: CKEditor 3.4
Component: General Version:
Keywords: IBM IE Cc:

Description

Table resize handles do not appear in IE7. Tried in IE7 mode using IE8. Version - Beta 3.4.

Attachments (4)

5890_ref.patch (6.4 KB) - added by Tobiasz Cudnik 9 years ago.
5890.patch (3.2 KB) - added by Tobiasz Cudnik 9 years ago.
5890_2.patch (2.6 KB) - added by Tobiasz Cudnik 9 years ago.
5890_3.patch (2.5 KB) - added by Frederico Caldeira Knabben 9 years ago.

Download all attachments as: .zip

Change History (15)

comment:1 Changed 9 years ago by Lynne Kues

Summary: Table resize not working for IE7Table column resize not working for IE7

comment:2 Changed 9 years ago by Tobiasz Cudnik

Keywords: Confirmed IE added
Owner: set to Tobiasz Cudnik
Status: newassigned

I can confirm issues also on native IE7. Resize handler does't appear there.

comment:3 Changed 9 years ago by Tobiasz Cudnik

It turns out IE7 doesn't allow elements outside of body tag to be available inside the document. Placing it inside of the body makes resize handler editable like other absolutely positioned elements.

It should be easily resolvable using contentEditable feature, which is currently during integration.

comment:4 Changed 9 years ago by Tobiasz Cudnik

Unfortunately contentEditable doesn't resolve this issue as IE's resize handlers are still visible (although we may prevent them from real resizing). I think we have to redesign this plugin to render it's resize element outside of document iframe.

Changed 9 years ago by Tobiasz Cudnik

Attachment: 5890_ref.patch added

comment:5 Changed 9 years ago by Tobiasz Cudnik

This is just reference patch, which still have issues with dimensions, mostly on IE.

The good news is the way it makes tableresize plugin to work does not depend on keeping element inside the editor.

Changed 9 years ago by Tobiasz Cudnik

Attachment: 5890.patch added

comment:6 Changed 9 years ago by Tobiasz Cudnik

Keywords: Review? added

Second patch doesn't change the way how resizer works, but it's affected by browser's resize handlers which are visible during resize.

This have only visual impact during resizing and works quite well in IE7.

comment:7 Changed 9 years ago by Frederico Caldeira Knabben

Keywords: Review- added; Review? removed
  • There are some foo/bar debug references in the code :/
  • We should not really have the resize handlers visible when resizing.
  • The scrollbar appears when moving the mouse over the resize spaces.

Changed 9 years ago by Tobiasz Cudnik

Attachment: 5890_2.patch added

comment:8 Changed 9 years ago by Tobiasz Cudnik

Keywords: Review? added; Review- removed

This patch adds workaround compatibility dedicated for IE7 only (native resize handlers are visible during column resize).

We're not able to do anything better now in reasonable time.

Changed 9 years ago by Frederico Caldeira Knabben

Attachment: 5890_3.patch added

comment:9 in reply to:  8 Changed 9 years ago by Frederico Caldeira Knabben

Keywords: IE added; Confirmed IE? removed
Owner: changed from Tobiasz Cudnik to Frederico Caldeira Knabben

Replying to tobiasz.cudnik:

(native resize handlers are visible during column resize).

Setting unselectable="on" did the trick, helping also simplifying the patch.

comment:10 Changed 9 years ago by Frederico Caldeira Knabben

Status: reviewassigned

This one will be fixed by #6017.

comment:11 Changed 9 years ago by Frederico Caldeira Knabben

Resolution: fixed
Status: assignedclosed

Confirmed it fixed at #6017.

Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy