Ticket #5902 (closed Bug: fixed)

Opened 4 years ago

Last modified 4 years ago

paste and pastetext dialogs can not be skinned easily.

Reported by: JoeK Owned by: tobiasz.cudnik
Priority: Normal Milestone: CKEditor 3.4
Component: UI : Dialogs Version: SVN (CKEditor) - OLD
Keywords: IBM Confirmed Review+ Cc: damo satya

Description

The paste and pastetext dialogs are built using HTML UI elements. The HTML contains hard-coded style attribute values, as the following code from the pastetext dialog shows:

{
type : 'html',
id : 'content',
style : 'width:340px;height:170px',
html :
	'<textarea style="' +
		'width:346px;' +
		'height:170px;' +
		'resize: none;' +
		'direction:' + editor.config.contentsLangDirection + ';' +
		'border:1px solid black;' +
		'background-color:white">' +
	'</textarea>',

As with the image and flash dialogs, can the tags in the HTML content be given an id attribute, and the style moved out to the skin's dialog.css. Only dynamic styles should remain.

Attachments

5902.patch (3.4 KB) - added by tobiasz.cudnik 4 years ago.
5902_2.patch (4.1 KB) - added by tobiasz.cudnik 4 years ago.

Change History

comment:1 Changed 4 years ago by fredck

  • Keywords Confirmed added

comment:2 Changed 4 years ago by tobiasz.cudnik

  • Status changed from new to assigned
  • Owner set to tobiasz.cudnik

comment:3 Changed 4 years ago by tobiasz.cudnik

  • Keywords Review? added

Changed 4 years ago by tobiasz.cudnik

comment:4 Changed 4 years ago by alfonsoml

  • Keywords Review- added; Review? removed

Maybe we should use a dialog.ui.textarea element instead of using a Html element with the textarea as the content?

And so, the basic style of border and background-color should be available for all the dialog.ui.textarea elements

Changed 4 years ago by tobiasz.cudnik

comment:5 Changed 4 years ago by tobiasz.cudnik

  • Keywords Review? added; Review- removed

This kind of inheritance is a good idea, fixed that in new patch.

comment:6 Changed 4 years ago by fredck

  • Keywords Review+ added; Review? removed

comment:7 Changed 4 years ago by tobiasz.cudnik

Fixed with [5705].

comment:8 Changed 4 years ago by tobiasz.cudnik

  • Status changed from assigned to closed
  • Resolution set to fixed
Note: See TracTickets for help on using tickets.
© 2003 – 2012 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy