Opened 14 years ago
Closed 13 years ago
#5924 closed Bug (fixed)
Allow flash plugin to recognize flash content without embed tag
| Reported by: | jstrahan | Owned by: | Sa'ar Zac Elias |
|---|---|---|---|
| Priority: | Normal | Milestone: | CKEditor 3.5.3 |
| Component: | General | Version: | 3.0 |
| Keywords: | Cc: |
Description
The Flash Plugin does not recognize flash content unless an embed tag is present. It would be nice if a cke_flash element/placeholder would be displayed in the editor when an <object> tag containing the "'application/x-shockwave-flash'" attribute is encountered.
To reproduce: go to flowplayer.org/plugins/javascript/embed.html press the get embed code button paste value in ckeditor
Attachments (4)
Change History (16)
Changed 14 years ago by
| Attachment: | 0001-enable-flash-detection-without-embed-tag.patch added |
|---|
Changed 14 years ago by
| Attachment: | example_embed_code.zip added |
|---|
comment:1 Changed 14 years ago by
| Keywords: | HasPatch added; flash removed |
|---|
comment:2 Changed 14 years ago by
| Keywords: | Confirmed added |
|---|
comment:3 Changed 13 years ago by
| Version: | → 3.0 |
|---|
comment:4 Changed 13 years ago by
| Milestone: | → CKEditor 3.5.2 |
|---|
comment:5 Changed 13 years ago by
Changed the "id" and "name" attributes from undefined to better values:
<object width="251" height="200" id="id1" name="name1" data="http://releases.flowplayer.org/swf/flowplayer-3.2.5.swf" type="application/x-shockwave-flash"><param name="movie" value="http://releases.flowplayer.org/swf/flowplayer-3.2.5.swf" /><param name="allowfullscreen" value="true" /><param name="allowscriptaccess" value="always" /><param name="flashvars" value='config={"clip":{"baseUrl":"http://blip.tv/file/get","url":"http://blip.tv/file/get/KimAronson-TwentySeconds1318.flv"},"playlist":[{"url":"http://blip.tv/file/get/KimAronson-TwentySeconds1318.flv","baseUrl":"http://blip.tv/file/get"},{"url":"http://blip.tv/file/get/N8inpasadena-Flowers457.flv","baseUrl":"http://blip.tv/file/get"}],"canvas":{"backgroundColor":"#112233"},"plugins":{"controls":{"time":false,"volume":false,"fullscreen":false},"content":{"url":"flowplayer.content-3.2.0.swf","html":"Flash plugins work too"}}}' /></object>
Changed 13 years ago by
| Attachment: | 5924.patch added |
|---|
comment:6 Changed 13 years ago by
| Owner: | set to Sa'ar Zac Elias |
|---|---|
| Status: | confirmed → review |
comment:7 Changed 13 years ago by
| Status: | review → review_failed |
|---|
Source URL is missing in IE and preview doesn't work in Chrome.
Changed 13 years ago by
| Attachment: | 5924_2.patch added |
|---|
comment:8 Changed 13 years ago by
| Status: | review_failed → review |
|---|
comment:9 Changed 13 years ago by
| Status: | review → review_failed |
|---|
In IE and Webkit, settings like alignment doesn't work with object only structure.
comment:10 Changed 13 years ago by
| Status: | review_failed → review |
|---|
Objects cannot recieve align="center". Other options will work.
IE's problem in reading params into the dialog is an existing bug, filed #7204.
comment:11 Changed 13 years ago by
| Status: | review → review_passed |
|---|
comment:12 Changed 13 years ago by
| Keywords: | HasPatch removed |
|---|---|
| Resolution: | → fixed |
| Status: | review_passed → closed |
Fixed with [6455].
Sample embed code from http://flowplayer.org/plugins/javascript/embed.html
<object width="251" height="200" id="undefined" name="undefined" data="http://releases.flowplayer.org/swf/flowplayer-3.2.5.swf" type="application/x-shockwave-flash"><param name="movie" value="http://releases.flowplayer.org/swf/flowplayer-3.2.5.swf" /><param name="allowfullscreen" value="true" /><param name="allowscriptaccess" value="always" /><param name="flashvars" value='config={"clip":{"baseUrl":"http://blip.tv/file/get","url":"http://blip.tv/file/get/KimAronson-TwentySeconds1318.flv"},"playlist":[{"url":"http://blip.tv/file/get/KimAronson-TwentySeconds1318.flv","baseUrl":"http://blip.tv/file/get"},{"url":"http://blip.tv/file/get/N8inpasadena-Flowers457.flv","baseUrl":"http://blip.tv/file/get"}],"canvas":{"backgroundColor":"#112233"},"plugins":{"controls":{"time":false,"volume":false,"fullscreen":false},"content":{"url":"flowplayer.content-3.2.0.swf","html":"Flash plugins work too"}}}' /></object>