Opened 7 years ago

Closed 7 years ago

#5955 closed Bug (fixed)

when we have combo box as first element in the Tool bar Application landmark is taking focus to Tool bar instead of Editor body

Reported by: Satya Minnekanti Owned by: Garry Yao
Priority: Normal Milestone: CKEditor 3.6.1
Component: Accessibility Version: 3.0
Keywords: IBM Cc: Damian, joek

Description

To reproduce the defect

  1. Try to customize the Tool bar in such a way that you have any of the Combo boxes(Styles,Paragraph Format,Font Name,Font Size) as the first element in the Tool bar.
  1. with JAWS On..Press Ctrl + Insert + ; to open landmarks dialog
  1. Select Application landmark in the dialog and press Tab to go to Application landmark

Expected Result:

Focus goes in to Editor body.

Actual Result:

Focus goes to Combo box in the Tool bar and when we press Tab or use Arrow keys focus goes to next combo box in the Tool bar and after the combo boxes,focus is going in to Editor body instead of next Tool bar icon.

This is affecting all out products,In all our products we have the the combo boxes as the first element in the Tool bar.

Attachments (2)

5955_debug.patch (1.6 KB) - added by Tobiasz Cudnik 7 years ago.
5955.patch (847 bytes) - added by Garry Yao 7 years ago.

Download all attachments as: .zip

Change History (14)

comment:1 Changed 7 years ago by Tobiasz Cudnik

Keywords: Confirmed added

comment:2 Changed 7 years ago by Frederico Caldeira Knabben

Milestone: CKEditor 3.4CKEditor 3.5

comment:3 Changed 7 years ago by Tobiasz Cudnik

Owner: set to Tobiasz Cudnik
Status: confirmedassigned

Changed 7 years ago by Tobiasz Cudnik

Attachment: 5955_debug.patch added

comment:4 Changed 7 years ago by Tobiasz Cudnik

It seems JAWS doesn't push focus in the right way. I've attached patch for reproduction, dedicated for IE.

This situation is also happening for default toolbar setting. From my point of view, if we can't control the focus (the event isn't fired), then we can't fix it. This case needs deeper investigation.

comment:5 Changed 7 years ago by Tobiasz Cudnik

Status: assignedpending

comment:6 Changed 7 years ago by Frederico Caldeira Knabben

It would be better to have an opinion from Freedom Scientific.

comment:7 Changed 7 years ago by Tobiasz Cudnik

I'm not sure if this isn't somehow related with focus issues we're facing in #6192...

Changed 7 years ago by Garry Yao

Attachment: 5955.patch added

comment:8 Changed 7 years ago by Garry Yao

Milestone: CKEditor 3.4.2

For me it's an unpunished of #3052.

comment:9 Changed 7 years ago by Garry Yao

Cc: damo,joekdamo, joek
Owner: changed from Tobiasz Cudnik to Garry Yao
Status: pendingreview
Version: 3.33.0

comment:10 Changed 7 years ago by Frederico Caldeira Knabben

Status: reviewreview_passed

Just in case,it's better to follow the button code, checking is instance.onfocus is defined before calling it. Please do so on commit.

comment:11 Changed 7 years ago by Frederico Caldeira Knabben

Milestone: CKEditor 3.6.1

comment:12 Changed 7 years ago by Garry Yao

Resolution: fixed
Status: review_passedclosed

Fixed with [6945].

Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy