Opened 7 years ago

Closed 7 years ago

#5959 closed Bug (fixed)

Dialog auto focus does not check for hidden tabs.

Reported by: Joe Kavanagh Owned by: Tobiasz Cudnik
Priority: Normal Milestone: CKEditor 3.4
Component: UI : Dialogs Version: SVN (CKEditor) - OLD
Keywords: IBM Confirmed Review+ Cc: Damian

Description (last modified by Tobiasz Cudnik)

When determining whether initial dialog focus should be on the first tab, dialog._.tabIdList.length is checked to see if the dialog has more then one tab. This will not take into consideration any tabs that are hidden. When a dialog has all but one tab hidden, and keyboard navigation is used, the dialog will not receive focus if CKEDITOR.config.dialog_startupFocusTab is set to true. Focus will remain on the toolbar.

The if statement is located in the CKEDITOR.dialog constructor in a dialog 'show' event listener, which is used to setup focus:

if ( editor.config.dialog_startupFocusTab
	&& me._.tabIdList.length > 1 )

could be changed to:

if ( editor.config.dialog_startupFocusTab
	&& me._.pageCount > 1 )

pageCount only gets incremented if the tab is not hidden.

Attachments (1)

5959.patch (453 bytes) - added by Tobiasz Cudnik 7 years ago.

Download all attachments as: .zip

Change History (5)

comment:1 Changed 7 years ago by Tobiasz Cudnik

Description: modified (diff)
Keywords: Confirmed HasPatch added
Owner: set to Tobiasz Cudnik
Status: newassigned

Changed 7 years ago by Tobiasz Cudnik

Attachment: 5959.patch added

comment:2 Changed 7 years ago by Tobiasz Cudnik

Keywords: Review? added; HasPatch removed

comment:3 Changed 7 years ago by Frederico Caldeira Knabben

Keywords: Review+ added; Review? removed

Great job JoeK ;)

comment:4 Changed 7 years ago by Tobiasz Cudnik

Resolution: fixed
Status: assignedclosed

Fixed with [5706].

Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy