Opened 14 years ago
Closed 14 years ago
#5959 closed Bug (fixed)
Dialog auto focus does not check for hidden tabs.
| Reported by: | Joe Kavanagh | Owned by: | Tobiasz Cudnik |
|---|---|---|---|
| Priority: | Normal | Milestone: | CKEditor 3.4 |
| Component: | UI : Dialogs | Version: | SVN (CKEditor) - OLD |
| Keywords: | IBM Confirmed Review+ | Cc: | Damian |
Description (last modified by )
When determining whether initial dialog focus should be on the first tab, dialog._.tabIdList.length is checked to see if the dialog has more then one tab. This will not take into consideration any tabs that are hidden. When a dialog has all but one tab hidden, and keyboard navigation is used, the dialog will not receive focus if CKEDITOR.config.dialog_startupFocusTab is set to true. Focus will remain on the toolbar.
The if statement is located in the CKEDITOR.dialog constructor in a dialog 'show' event listener, which is used to setup focus:
if ( editor.config.dialog_startupFocusTab && me._.tabIdList.length > 1 )
could be changed to:
if ( editor.config.dialog_startupFocusTab && me._.pageCount > 1 )
pageCount only gets incremented if the tab is not hidden.
Attachments (1)
Change History (5)
comment:1 Changed 14 years ago by
| Description: | modified (diff) |
|---|---|
| Keywords: | Confirmed HasPatch added |
| Owner: | set to Tobiasz Cudnik |
| Status: | new → assigned |
Changed 14 years ago by
| Attachment: | 5959.patch added |
|---|
comment:2 Changed 14 years ago by
| Keywords: | Review? added; HasPatch removed |
|---|
comment:3 Changed 14 years ago by
| Keywords: | Review+ added; Review? removed |
|---|
Note: See
TracTickets for help on using
tickets.
Great job JoeK ;)