Ticket #5959 (closed Bug: fixed)

Opened 4 years ago

Last modified 4 years ago

Dialog auto focus does not check for hidden tabs.

Reported by: JoeK Owned by: tobiasz.cudnik
Priority: Normal Milestone: CKEditor 3.4
Component: UI : Dialogs Version: SVN (CKEditor) - OLD
Keywords: IBM Confirmed Review+ Cc: damo

Description (last modified by tobiasz.cudnik) (diff)

When determining whether initial dialog focus should be on the first tab, dialog._.tabIdList.length is checked to see if the dialog has more then one tab. This will not take into consideration any tabs that are hidden. When a dialog has all but one tab hidden, and keyboard navigation is used, the dialog will not receive focus if CKEDITOR.config.dialog_startupFocusTab is set to true. Focus will remain on the toolbar.

The if statement is located in the CKEDITOR.dialog constructor in a dialog 'show' event listener, which is used to setup focus:

if ( editor.config.dialog_startupFocusTab
	&& me._.tabIdList.length > 1 )

could be changed to:

if ( editor.config.dialog_startupFocusTab
	&& me._.pageCount > 1 )

pageCount only gets incremented if the tab is not hidden.

Attachments

5959.patch (453 bytes) - added by tobiasz.cudnik 4 years ago.

Change History

comment:1 Changed 4 years ago by tobiasz.cudnik

  • Owner set to tobiasz.cudnik
  • Status changed from new to assigned
  • Description modified (diff)
  • Keywords Confirmed HasPatch added

Changed 4 years ago by tobiasz.cudnik

comment:2 Changed 4 years ago by tobiasz.cudnik

  • Keywords Review? added; HasPatch removed

comment:3 Changed 4 years ago by fredck

  • Keywords Review+ added; Review? removed

Great job JoeK ;)

comment:4 Changed 4 years ago by tobiasz.cudnik

  • Status changed from assigned to closed
  • Resolution set to fixed

Fixed with [5706].

Note: See TracTickets for help on using tickets.
© 2003 – 2012 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy