Opened 14 years ago
Closed 14 years ago
#5979 closed New Feature (fixed)
BIDI: Bidi buttons should be selected in toolbar to reflect the current direction
Reported by: | Damian | Owned by: | Sa'ar Zac Elias |
---|---|---|---|
Priority: | Normal | Milestone: | CKEditor 3.4 |
Component: | General | Version: | SVN (CKEditor) - OLD |
Keywords: | IBM Confirmed | Cc: | Joe Kavanagh, Satya |
Description
There are a number of cases where it is difficult for a user to determine if the currently selected block has dir="RTL" or dir="LTR". E.g. we could have a paragraph that has dir="RTL" but aligned to the left.
To make it clear to a user which language direction is active, the toolbar buttons should select the relevant style.
- When a block element has dir="LTR" or dir="RTL" the matching button in the toolbar should be selected.
- When there is no explicit direction set on the block element, the toolbar button should show the currently active document level direction. E.g. if the document is LTR and the current paragraph does not have a dir attribute set, the LTR button in the toolbar should be selected. This is similar to the default behavior of the paragraph alignment buttons.
Attachments (1)
Change History (4)
Changed 14 years ago by
Attachment: | 5979.patch added |
---|
comment:1 Changed 14 years ago by
Keywords: | Confirmed Review? added |
---|---|
Owner: | set to Sa'ar Zac Elias |
Status: | new → assigned |
Version: | → SVN (CKEditor) |
comment:2 Changed 14 years ago by
Status: | review → review_passed |
---|
comment:3 Changed 14 years ago by
Resolution: | → fixed |
---|---|
Status: | review_passed → closed |
Fixed with [5729].
Using getComputedStyle to calculate the current direction of the element.