Opened 9 years ago

Closed 9 years ago

#5979 closed New Feature (fixed)

BIDI: Bidi buttons should be selected in toolbar to reflect the current direction

Reported by: Damian Owned by: Sa'ar Zac Elias
Priority: Normal Milestone: CKEditor 3.4
Component: General Version: SVN (CKEditor) - OLD
Keywords: IBM Confirmed Cc: Joe Kavanagh, Satya

Description

There are a number of cases where it is difficult for a user to determine if the currently selected block has dir="RTL" or dir="LTR". E.g. we could have a paragraph that has dir="RTL" but aligned to the left.

To make it clear to a user which language direction is active, the toolbar buttons should select the relevant style.

  1. When a block element has dir="LTR" or dir="RTL" the matching button in the toolbar should be selected.
  2. When there is no explicit direction set on the block element, the toolbar button should show the currently active document level direction. E.g. if the document is LTR and the current paragraph does not have a dir attribute set, the LTR button in the toolbar should be selected. This is similar to the default behavior of the paragraph alignment buttons.

Attachments (1)

5979.patch (885 bytes) - added by Sa'ar Zac Elias 9 years ago.

Download all attachments as: .zip

Change History (4)

Changed 9 years ago by Sa'ar Zac Elias

Attachment: 5979.patch added

comment:1 Changed 9 years ago by Sa'ar Zac Elias

Keywords: Confirmed Review? added
Owner: set to Sa'ar Zac Elias
Status: newassigned
Version: SVN (CKEditor)

Using getComputedStyle to calculate the current direction of the element.

comment:2 Changed 9 years ago by Frederico Caldeira Knabben

Status: reviewreview_passed

comment:3 Changed 9 years ago by Sa'ar Zac Elias

Resolution: fixed
Status: review_passedclosed

Fixed with [5729].

Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy