Opened 7 years ago

Closed 7 years ago

#6010 closed Bug (fixed)

Automatic Background Color is Incorrectly displayed as "Black" in UI when it is actually "White"

Reported by: Satya Minnekanti Owned by: Sa'ar Zac Elias
Priority: Normal Milestone: CKEditor 3.5
Component: General Version: 3.0
Keywords: IBM Cc: Damian, joek

Description

To reproduce the defect

  1. Open Ajax sample.
  1. Enter some text in the Editor,Then click "Background color" menu,select the "Automatic" color.

Problem:

The Automatic color of Background color menu marks black,but it is actually white.

Attachments (3)

6010.patch (2.1 KB) - added by Sa'ar Zac Elias 7 years ago.
6010_1.patch (2.6 KB) - added by Sa'ar Zac Elias 7 years ago.
6010_2.patch (2.5 KB) - added by Sa'ar Zac Elias 7 years ago.

Download all attachments as: .zip

Change History (16)

comment:1 Changed 7 years ago by Frederico Caldeira Knabben

Status: newconfirmed

We can try using the document <body> color instead of the black square. Would that be enough?

comment:2 in reply to:  1 Changed 7 years ago by Satya Minnekanti

Replying to fredck:

We can try using the document <body> color instead of the black square. Would that be enough?

I think that should be OK

comment:3 Changed 7 years ago by Frederico Caldeira Knabben

Milestone: CKEditor 3.5

comment:4 Changed 7 years ago by Sa'ar Zac Elias

Owner: set to Sa'ar Zac Elias
Status: confirmedassigned

Changed 7 years ago by Sa'ar Zac Elias

Attachment: 6010.patch added

comment:5 Changed 7 years ago by Sa'ar Zac Elias

Status: assignedreview

comment:6 Changed 7 years ago by Sa'ar Zac Elias

Version: 3.33.0

comment:7 Changed 7 years ago by Frederico Caldeira Knabben

Milestone: CKEditor 3.4.1CKEditor 3.5

comment:8 in reply to:  1 Changed 7 years ago by Garry Yao

Status: reviewreview_failed

Replying to fredck:

We can try using the document <body> color instead of the black square. Would that be enough?

It's counter-intuitive to fill with <body> color as the semantic of 'auto' color should be explained instead as 'computed color style of the current element'.

Changed 7 years ago by Sa'ar Zac Elias

Attachment: 6010_1.patch added

comment:9 Changed 7 years ago by Sa'ar Zac Elias

Status: review_failedreview

comment:10 Changed 7 years ago by Garry Yao

Status: reviewreview_failed

Fails with the following content when open panel on 'cell2'.

<table style="width: 500px; background-color: #dcdcdc;">
	<tbody>
		<tr>
			<td>
				cell1</td>
			<td bgcolor="#9acd32">
				cell2</td>
		</tr>
	</tbody>
</table>

Please simply use the following to check blocks:

						var path = new CKEDITOR.dom.elementPath( editor.getSelection().getStartElement() );
						block = path.block || path.blockLimit;

Changed 7 years ago by Sa'ar Zac Elias

Attachment: 6010_2.patch added

comment:11 Changed 7 years ago by Sa'ar Zac Elias

Status: review_failedreview

comment:12 Changed 7 years ago by Garry Yao

Status: reviewreview_passed

A very informative feature added!

comment:13 Changed 7 years ago by Sa'ar Zac Elias

Resolution: fixed
Status: review_passedclosed

Fixed with [5935].

Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy