BIDI: Direction of Increase Indent & Decrease Indent icons are not reversed after changing Lang direction to RTL

[Satya Minnekanti]

To reproduce the defect:

1. Open Ajax sample.

2. Type some text, Select the text and click on RTL icon in the Tool bar.

3. keep the cursor in the Paragraph and look for the direction of Increase Indent & Decrease Indent Icons.

Expected Result:

Direction of the Arrow in Increase Indent icon should be pointing from right to left and direction of Arrow in Decrease Indent icons should be pointing from right to left, since we have changed the direction of Paragraph from left to right.

Actual Result:

Direction of Increase Indent & Decrease Indent icons are not reversed, they are sill showing the same direction of Indentation for a Left to Right paragraph.

[Sa'ar Zac Elias]

The problem here is that the icon set is only suitable for LTR. A RTL version of the icon set will be handled in #3840.

[Tobiasz Cudnik]

Attached patch fixes Kama skin. Just replace image.png in main skin folder and place second one for RTL in same dir.

[Frederico Caldeira Knabben]

The effect is pretty nice. There are just a few minor issues:

• At lines 44 and 45, there is no need to use evt.editor, because we already have the editor variable.

• Being this a UI feature that touches the toolbar, editor.lang.dir should be checked, not contentsLangDirection.

• In both images, the last <div> container icons have been mistakenly mixed with the list icons, breaking them.

• The following icons should be also reflected in the rtl strip: Source, Anchor, Find and Page Break for Printing.

• It's ok to have the box at the left side in the Past from Word icon, but the small Word logo (W) must not be reflected.

I would also ask Saar to give us his opinion, as he's our native rtl man.

[Sa'ar Zac Elias]

• The rtl icons should also be present on the context menu.
• The textarea icon should also be changed (the scrollbar should go on the left), and so does the selectbox icon.
• A few more icons that could be reflected (not an issue though, we can leave them as they are): Text color, Preview and Show blocks.

I'm closing #3840 as a DUP for now.

[Tobiasz Cudnik]

/_source/skins/kama/

[Tobiasz Cudnik]

/_source/skins/kama/

[Tobiasz Cudnik]

Second patch address mentioned issues, including mirroring context menu icons depending on the selected element (like lists).

Personally i think we can also change all icons containing letters, like "search & replace".

[Sa'ar Zac Elias]

The text in the textarea icon is now flipped in the rtl strip. Other than that I think you can now spread it to the other skins.

[Sa'ar Zac Elias]

Just to be safe of any DOM modification by the user, let's use editor.container instead of editor.element.getNext() (L47 in the bidi plugin).

[Tobiasz Cudnik]

Fixed with [5838].

[Sa'ar Zac Elias]

For reference, [5839] applies the change descibed in comment:11 also for the context menu.