Opened 15 years ago
Closed 14 years ago
#6083 closed Bug (fixed)
IE: Selection collapses when inserting special char
Reported by: | Frederico Caldeira Knabben | Owned by: | Garry Yao |
---|---|---|---|
Priority: | Normal | Milestone: | CKEditor 3.4.2 |
Component: | General | Version: | 3.2.2 |
Keywords: | Cc: |
Description
- Clear the cache and load the editor.
- Select any work by double click.
- Click the "Insert Special Character" button.
- Click on any character.
Note that the char has been added at the start of the selection, instead of replacing it.
Attachments (3)
Change History (14)
comment:1 Changed 15 years ago by
Status: | new → confirmed |
---|---|
Version: | → 3.2.2 |
comment:2 Changed 15 years ago by
Owner: | set to Tobiasz Cudnik |
---|---|
Status: | confirmed → assigned |
Changed 15 years ago by
Attachment: | 6083.patch added |
---|
comment:3 Changed 15 years ago by
Status: | assigned → review |
---|
Adding selection lock when opening a dialog and changing order of instruction a bit in specialchars dialog seems to resolve the issue.
comment:4 Changed 14 years ago by
Status: | review → review_failed |
---|
Same issue applies to other dialogs including form fields, the problem is that selection range is not correctly figured out at the first time.
Changed 14 years ago by
Attachment: | 6083_2.patch added |
---|
comment:5 Changed 14 years ago by
It turns out that the selection restoring logic, might normalize the text nodes thus potentially invalidate the locked selection's correctness, proposing here an isolated approach between these two.
comment:7 Changed 14 years ago by
This's a fundamental change, give it your review pls, and we need a 3rd involved in.
comment:8 follow-up: 9 Changed 14 years ago by
Removing focus from onInsertHtml and onInsertElement will break #6358 again in webkit.
Changed 14 years ago by
Attachment: | 6083_3.patch added |
---|
comment:9 Changed 14 years ago by
Owner: | changed from Tobiasz Cudnik to Garry Yao |
---|---|
Status: | review_failed → review |
Replying to tobiasz.cudnik:
Removing focus from onInsertHtml and onInsertElement will break #6358 again in webkit.
I don't get #6358 broken after the patch, but anyway the previous patch's impact could be even reduced, propose the new one here.
comment:10 Changed 14 years ago by
Status: | review → review_passed |
---|
comment:11 Changed 14 years ago by
Resolution: | → fixed |
---|---|
Status: | review_passed → closed |
Fixed with [5962].
Confirmed with version 3.2.2. Ok with the 3.2.1.