Opened 7 years ago

Closed 7 years ago

#6083 closed Bug (fixed)

IE: Selection collapses when inserting special char

Reported by: Frederico Caldeira Knabben Owned by: Garry Yao
Priority: Normal Milestone: CKEditor 3.4.2
Component: General Version: 3.2.2
Keywords: Cc:

Description

  1. Clear the cache and load the editor.
  2. Select any work by double click.
  3. Click the "Insert Special Character" button.
  4. Click on any character.

Note that the char has been added at the start of the selection, instead of replacing it.

Attachments (3)

6083.patch (1.2 KB) - added by Tobiasz Cudnik 7 years ago.
6083_2.patch (2.6 KB) - added by Garry Yao 7 years ago.
6083_3.patch (684 bytes) - added by Garry Yao 7 years ago.

Download all attachments as: .zip

Change History (14)

comment:1 Changed 7 years ago by Frederico Caldeira Knabben

Status: newconfirmed
Version: 3.2.2

Confirmed with version 3.2.2. Ok with the 3.2.1.

comment:2 Changed 7 years ago by Tobiasz Cudnik

Owner: set to Tobiasz Cudnik
Status: confirmedassigned

Changed 7 years ago by Tobiasz Cudnik

Attachment: 6083.patch added

comment:3 Changed 7 years ago by Tobiasz Cudnik

Status: assignedreview

Adding selection lock when opening a dialog and changing order of instruction a bit in specialchars dialog seems to resolve the issue.

comment:4 Changed 7 years ago by Garry Yao

Status: reviewreview_failed

Same issue applies to other dialogs including form fields, the problem is that selection range is not correctly figured out at the first time.

Changed 7 years ago by Garry Yao

Attachment: 6083_2.patch added

comment:5 Changed 7 years ago by Garry Yao

It turns out that the selection restoring logic, might normalize the text nodes thus potentially invalidate the locked selection's correctness, proposing here an isolated approach between these two.

comment:6 Changed 7 years ago by Tobiasz Cudnik

I understand that 6083_2.patch patch is targeted to review ?

comment:7 Changed 7 years ago by Garry Yao

This's a fundamental change, give it your review pls, and we need a 3rd involved in.

comment:8 Changed 7 years ago by Tobiasz Cudnik

Removing focus from onInsertHtml and onInsertElement will break #6358 again in webkit.

Changed 7 years ago by Garry Yao

Attachment: 6083_3.patch added

comment:9 in reply to:  8 Changed 7 years ago by Garry Yao

Owner: changed from Tobiasz Cudnik to Garry Yao
Status: review_failedreview

Replying to tobiasz.cudnik:

Removing focus from onInsertHtml and onInsertElement will break #6358 again in webkit.

I don't get #6358 broken after the patch, but anyway the previous patch's impact could be even reduced, propose the new one here.

comment:10 Changed 7 years ago by Sa'ar Zac Elias

Status: reviewreview_passed

comment:11 Changed 7 years ago by Garry Yao

Resolution: fixed
Status: review_passedclosed

Fixed with [5962].

Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy