Opened 7 years ago

Closed 7 years ago

#6100 closed Bug (fixed)

BIDI: when we change Table language direction indentation of text in Table cells is not applied correctly.

Reported by: Satya Minnekanti Owned by: Tobiasz Cudnik
Priority: Normal Milestone: CKEditor 3.4.2
Component: General Version: 3.3
Keywords: IBM Cc: Damian, joek

Description

To reproduce the defect:

  1. Open Ajax sample.
  1. Insert a Table and enter text in all Table cells, Indent the text in few cells.
  1. Activate Context menu and select Table properties option.
  1. In the Table Properties dialog on Advanced Tab, change the Language direction of the Table to Right to Left(RTL) and click OK button.

Expected Result:

Table language direction is changed to right,Table cells should be shown as reversed,Table Cells & text in Table cells should appear as a mirror image of Table in previous step and indentation for Paragraphs in Table cells should be changed from left to right.

Actual Result:

Table language direction is changed to right,Table cells are shown as reversed,Table Cells & text in Table cells are appearing as a mirror image of Table in previous step but the indentation for Paragraphs in Table cells still shown as left.

Attachments (3)

Screenshot_6100.png (28.4 KB) - added by Frederico Caldeira Knabben 7 years ago.
Screenshot with the current results.
6100.patch (3.2 KB) - added by Tobiasz Cudnik 7 years ago.
6100_2.patch (3.2 KB) - added by Tobiasz Cudnik 7 years ago.

Download all attachments as: .zip

Change History (19)

Changed 7 years ago by Frederico Caldeira Knabben

Attachment: Screenshot_6100.png added

Screenshot with the current results.

comment:1 Changed 7 years ago by Frederico Caldeira Knabben

Status: newpending

It WFM here. Maybe I simply didn't understand the issue. So, just to be sure, I've attached screenshots of the editor, before and after changing the table direction.

Should we have anything different here?

comment:2 in reply to:  1 Changed 7 years ago by Satya Minnekanti

Replying to fredck:

It WFM here. Maybe I simply didn't understand the issue. So, just to be sure, I've attached screenshots of the editor, before and after changing the table direction.

Should we have anything different here?

we are talking about indentation of the text in Table cells and it's not changing when you change language direction.you have not applied any indentation to the text in your Table cells.

look at step 2 i have asked to apply some indentation to the text in few cells.

comment:3 Changed 7 years ago by Frederico Caldeira Knabben

Status: pendingconfirmed

Ok, my fault. Step 2 has two steps on it, and the second got unobserved.

The problem is that the dialog doesn't perform the same margin switching procedure that is instead executed by the BiDi buttons.

It looks like we'll have to implement a generic solution for it, controlled by the indentation plugin, so we make this feature more generic.

comment:4 Changed 7 years ago by Tobiasz Cudnik

I think we just miss lang switch event, to which other plugins could subscribe their content changes.

comment:5 Changed 7 years ago by Frederico Caldeira Knabben

Something similar to the event we've introduced for the Remove Format feature would do. So, whenever some code changes the direction of an element, the "dirChanged" event is fired.

comment:6 Changed 7 years ago by Tobiasz Cudnik

Owner: set to Tobiasz Cudnik
Status: confirmedassigned

Changed 7 years ago by Tobiasz Cudnik

Attachment: 6100.patch added

comment:7 Changed 7 years ago by Tobiasz Cudnik

Status: assignedreview

comment:8 Changed 7 years ago by Damian

Can we assign this to 3.4.2?

comment:9 in reply to:  8 Changed 7 years ago by Garry Yao

Replying to damo:

Can we assign this to 3.4.2?

Ok as it's quite a small change, right now we'll not be adding any more to 3.4.2.

comment:10 Changed 7 years ago by Garry Yao

Milestone: CKEditor 3.4.2
Status: reviewreview_passed

comment:11 Changed 7 years ago by Tobiasz Cudnik

Resolution: fixed
Status: review_passedclosed

Fixed with [5954].

comment:12 Changed 7 years ago by Garry Yao

Resolution: fixed
Status: closedreopened

Changeset is broken new table creation, revert with [5959], patch must be revised.

comment:13 Changed 7 years ago by Garry Yao

Status: reopenedconfirmed

Changed 7 years ago by Tobiasz Cudnik

Attachment: 6100_2.patch added

comment:14 Changed 7 years ago by Tobiasz Cudnik

Status: confirmedreview

The reason was lack of a parent during the table creation. Ive added a dedicated check for this situation.

comment:15 Changed 7 years ago by Garry Yao

Status: reviewreview_passed

comment:16 Changed 7 years ago by Tobiasz Cudnik

Resolution: fixed
Status: review_passedclosed

Fixed with [5968].

Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy