Remove block style via the list

[Sa'ar Zac Elias]

Currently it's impossible to remove block styles via the combo by clicking on the active option.

[Tobiasz Cudnik]

Seems to be DUP of #5336.

[Garry Yao]

The patch mixes "applyBlockStyle" and "removeBlockStyle" logic together which is bad.

[Garry Yao]

Replying to tobiasz.cudnik:

Seems to be DUP of #5336.

We're talking of block style, no longer object style here.

[Sa'ar Zac Elias]

Yep, block styles this time.

[Garry Yao]

Two problems:

1. Current implementation doesn't preserve other styles on block;

   <h3 style="color: blue;background-color:blue">heading</h3>
   

2. Format combo not aligned;

[Garry Yao]

We could reuse "removeFromElement" function：

1. Remove only styles in case of partial match;
2. Revert block in case of full match.

[Garry Yao]

The patch fails the following TC:

1. Remove "h1" format from the following content:

   <div>
   	<h1>^paragraph1</h1>
   </div>
   

• Expected Result:

  <div>
  	<p>paragraph1</p>
  </div>
  

• Actual Result:

  <div>
  	paragraph1
  </div>
  

[Sa'ar Zac Elias]

Using enterMode=BR and the following contents and selection:

<h3 style="color: red;">
	Test</h3>

Removing the style should not put a BR on top (first element in the doc).

[Sa'ar Zac Elias]

Block removal does not handle extra styles/attributes.

[Garry Yao]

A simplified patch to 6107_6.

[Sa'ar Zac Elias]

The new patch doesn't cover the case when you apply "red title" style and then remove "heading 3" style (result should be a styled DIV).

[Garry Yao]

Though not related, I'd like to propose the alignment of behavior when removing inline style, e.g. remove bold style from the following content:

<p><strong style="color:red">sam[ple</strong> text].</p>

[Garry Yao]

As #6026 is already opened for the above case, let's just stack the patch to be used there. R+ for 6107_8.patch

[Sa'ar Zac Elias]

Fixed with [6344].