Opened 15 years ago

Last modified 15 years ago

#6107 closed Bug

Remove block style via the list — at Version 7

Reported by: Sa'ar Zac Elias Owned by: Sa'ar Zac Elias
Priority: Normal Milestone: CKEditor 3.5.1
Component: Core : Styles Version: 3.0
Keywords: Cc:

Description (last modified by Sa'ar Zac Elias)

Currently it's impossible to remove block styles via the combo by clicking on the active option.

Change History (9)

comment:1 Changed 15 years ago by Sa'ar Zac Elias

Owner: set to Sa'ar Zac Elias
Status: newassigned

Changed 15 years ago by Sa'ar Zac Elias

Attachment: 6107.patch added

comment:2 Changed 15 years ago by Sa'ar Zac Elias

Status: assignedreview

comment:3 Changed 15 years ago by Tobiasz Cudnik

Seems to be DUP of #5336.

comment:4 Changed 15 years ago by Wiktor Walc

Milestone: CKEditor 3.5.1

comment:5 Changed 15 years ago by Garry Yao

Status: reviewreview_failed

The patch mixes "applyBlockStyle" and "removeBlockStyle" logic together which is bad.

comment:6 in reply to:  3 Changed 15 years ago by Garry Yao

Replying to tobiasz.cudnik:

Seems to be DUP of #5336.

We're talking of block style, no longer object style here.

comment:7 Changed 15 years ago by Sa'ar Zac Elias

Description: modified (diff)
Status: review_failedassigned
Summary: Remove object style via the listRemove block style via the list

Yep, block styles this time.

Changed 15 years ago by Sa'ar Zac Elias

Attachment: 6107_2.patch added
Note: See TracTickets for help on using tickets.
© 2003 – 2022, CKSource sp. z o.o. sp.k. All rights reserved. | Terms of use | Privacy policy