Opened 14 years ago
Closed 14 years ago
#6129 closed Bug (fixed)
BIDI: Show Blocks should show the HTML Tags on the Right for RTL Languages
| Reported by: | Satya Minnekanti | Owned by: | Sa'ar Zac Elias |
|---|---|---|---|
| Priority: | Normal | Milestone: | CKEditor 3.4.1 |
| Component: | General | Version: | 3.0 |
| Keywords: | IBM | Cc: | Damian, joek |
Description
To reproduce the defect:
- Open Language sample and change the language to Hebrew or Arabic.
- Type some text and click on Show Blocks icon.
Expected Result:
Blocks in the Editor body is shown and HTML Tags for the Paragraphs are displayed on the right hand side since we are using a Right to Left(RTL) Language sample.
Actual Result:
Blocks in the Editor body is shown and HTML Tags for the Paragraphs are displayed on the left hand side.
Attachments (3)
Change History (10)
comment:1 Changed 14 years ago by
| Milestone: | → CKEditor 3.4.1 |
|---|---|
| Owner: | set to Sa'ar Zac Elias |
| Status: | new → assigned |
| Version: | 3.4 Beta → 3.0 |
Changed 14 years ago by
| Attachment: | 6129.patch added |
|---|
comment:2 Changed 14 years ago by
| Status: | assigned → review |
|---|
comment:3 Changed 14 years ago by
| Status: | review → review_failed |
|---|
Changed 14 years ago by
| Attachment: | images.zip added |
|---|
comment:4 Changed 14 years ago by
| Status: | review_failed → review |
|---|
comment:5 Changed 14 years ago by
The new files are still bad. Not the labels are out of alignment.
I'll come with new files to be used on commit.
Changed 14 years ago by
| Attachment: | images_2.zip added |
|---|
comment:6 Changed 14 years ago by
| Status: | review → review_passed |
|---|
comment:7 Changed 14 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | review_passed → closed |
Fixed with [5871].
Note: See
TracTickets for help on using
tickets.
The patch looks good, but the positioning of the images are still incorrect, because of the extra white-space they have at the right side (some of them even missing it).
So, before proceeding with this patch, please commit new images directly, being sure all of them have 4px padding at right and left.