Opened 14 years ago
Closed 13 years ago
#6150 closed Bug (fixed)
Select color dialog is broken in Safari 3
| Reported by: | Wiktor Walc | Owned by: | Sa'ar Zac Elias |
|---|---|---|---|
| Priority: | Normal | Milestone: | CKEditor 3.4.3 |
| Component: | General | Version: | 3.3 |
| Keywords: | Cc: |
Description
Since CKEditor 3.3 the "Select color" dialog is broken in Safari 3. To reproduce press "Background color" -> "More colors".
Confirmed on Safari 3.2.3 @ XP, it might be worth to check what caused it because I do not see this error in CKEditor 3.2.2.
Attachments (2)
Change History (13)
Changed 14 years ago by
| Attachment: | select_color_safari3.jpg added |
|---|
comment:1 Changed 14 years ago by
| Status: | new → confirmed |
|---|
comment:2 Changed 14 years ago by
comment:3 Changed 14 years ago by
| Owner: | set to Tobiasz Cudnik |
|---|---|
| Status: | confirmed → assigned |
comment:4 Changed 14 years ago by
| Milestone: | CKEditor 3.4.1 → CKEditor 3.5 |
|---|
This error is due to too much markup inside a color table. It may be partially caused by complicated dialog markup itself.
Removing some parts of all rows (like styles, aria and events) makes color table visible. Reducing number of rows inside of table also results in visible table.
I'm proposing postponing it to 3.5 and rewriting it to styled UL list.
comment:5 Changed 14 years ago by
Based on the screenshot, it looks like a broken innerHTML assignment. Maybe the fix is not so hard, and we may not need such a drastic change.
Let's have some further investigation before proceeding with it.
comment:6 Changed 14 years ago by
| Milestone: | CKEditor 3.5 → CKeditor 3.4.3 |
|---|
comment:7 Changed 13 years ago by
| Owner: | Tobiasz Cudnik deleted |
|---|---|
| Status: | assigned → new |
comment:8 Changed 13 years ago by
| Owner: | set to Sa'ar Zac Elias |
|---|---|
| Status: | new → assigned |
Changed 13 years ago by
| Attachment: | 6150.patch added |
|---|
comment:9 Changed 13 years ago by
| Status: | assigned → review |
|---|
The event call breaks the innerHTML assignment.
comment:11 Changed 13 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | review_passed → closed |
Fixed with [6141].
Works well with Safari 4.