Opened 14 years ago
Closed 13 years ago
#6308 closed Bug (fixed)
"vertical" resize_dir still sets width CSS
Reported by: | Leonard Lee | Owned by: | Garry Yao |
---|---|---|---|
Priority: | Normal | Milestone: | CKEditor 3.6.3 |
Component: | UI : Toolbar | Version: | 3.4 |
Keywords: | Cc: | mcianc@… |
Description (last modified by )
When resize_dir is configured to be "vertical", only vertical size changes should be allowed. However, after some vertical resizing, a width CSS style (in px) is set on the editor span. For example:
style="width:1019px"
This is a problem if the editor is supposed to be 100% wide. The editor is now stuck at being the same width, even when the window/container resizes.
The same issue probably applies to "horizontal" resize_dir, but with a height CSS style.
Both issues can be fixed by changing the editor resize function call in resize/plugin.js line43 to:
editor.resize( resizeHorizontal ? width : null, resizeVertical ? height : null );
This will cause the width/height to only be changed when necessary.
Attachments (1)
Change History (10)
comment:1 Changed 14 years ago by
Description: | modified (diff) |
---|---|
Keywords: | HasPatch added; resize removed |
Status: | new → confirmed |
comment:2 Changed 14 years ago by
Cc: | mcianc@… added |
---|
comment:4 Changed 14 years ago by
Changed 13 years ago by
Attachment: | 6308.patch added |
---|
comment:7 Changed 13 years ago by
Component: | General → UI : Toolbar |
---|---|
Keywords: | HasPatch removed |
Owner: | set to Garry Yao |
Status: | confirmed → review |
We dont need to fix the horizontal-only resize since percentage val is not supported for editor height.
comment:8 Changed 13 years ago by
Milestone: | → CKEditor 3.6.3 |
---|---|
Status: | review → review_passed |
Please fix the coding style when committing.
comment:9 Changed 13 years ago by
Resolution: | → fixed |
---|---|
Status: | review_passed → closed |
Fixed with [7386].
Confirmed. After applying provided change, editor resizes itself depending on window size