Opened 12 years ago

Closed 8 years ago

#633 closed New Feature (fixed)

Change cyclis search implementation

Reported by: bngobngo@… Owned by:
Priority: Normal Milestone:
Component: UI : Dialogs Version:
Keywords: SF Confirmed Cc:

Description

Hi.

Would be nice if you could add a cyclic search checkbox to the find text dialog.

Today: If cursor is in middle of text and you search for a word that happend to be below cursor you find it, but you will not if word is above the cursor position.

Implementing a cyclic seach checkbox in the search dialog with default on, would make it more intuitive.


Moved from SF:
http://sourceforge.net/tracker/index.php?func=detail&aid=1184837&group_id=75348&atid=543656

Change History (5)

comment:1 Changed 12 years ago by Martin Kou

Reporter: changed from Martin Kou to bngobngo@…

comment:2 Changed 11 years ago by Wojciech Olchawa

Component: GeneralUI : Dialogs
Resolution: invalid
Status: newclosed

It works in the current version 2.6 beta. All of the searched words are found properly.

comment:3 Changed 11 years ago by bongobongo

Resolution: invalid
Status: closedreopened

I think the current implementation in 2.6 beta is no good.

Lets say I have inserted the following text in the editor: hello

this is a test

hello

this is a test

hello

If I now place the cursor somewhere inside the first occurence of "this is a test" and then click the Find button, and then type "hello" in the "Find what" textbox, then this happens:

The find routine start searching first from the very beginning of the content of the editor, even if my current cursor position is not in the beginning of the text.

So first "hello" found is actually above my curren cursor postion in the text.

To me, it looks that this implementation was a "quick and dirty" fix to manage to find all the occurences of the word sought (compared to previous implementations).

HERE IS A BETTER IMPLEMENTATION (IMHO)

1. The "find routine" should start searching from the current cursor position in the text.

2. And then, if word sought was not found untill end of editor, then it should start from the top of the editor, automatically without any questions asked.

3 And then when searched all the text untill "find routine" again comes to the place where the cursor position is, then the user should get a message asking something like this:

All text has been searched, do you want to continue searching?

If you then confirm (you want to continue searching), then the Find dialog should not close, and you should be able to continue hitting the Find button in the search dialog.

I find it truly annoying that the find routine start from the beginning of the editor if my current cursor position is somewhere else in the editor. A truly strange search implementation that is....

Just my 5c

comment:4 Changed 11 years ago by Wojciech Olchawa

Keywords: Confirmed added
Summary: Could you add cyclic search checkbox to the find text dialogChange cyclis search implementation

implementation

comment:5 Changed 8 years ago by Garry Yao

Resolution: fixed
Status: reopenedclosed

This's now fixed in v3.

Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy