Opened 7 years ago

Closed 7 years ago

#6375 closed Bug (fixed)

[IE] Exception thrown when hiding editor in some cases

Reported by: Damian Owned by: Frederico Caldeira Knabben
Priority: Normal Milestone: CKEditor 3.4.2
Component: General Version: 3.4
Keywords: IBM HasPatch Cc:

Description

When the editor is hidden right after a blur event, e.g. contained in a div with display="none", the call to selection.empty() throws an error. This code is only invoked in IE (< 8)

A work around for this issue is to catch the exception and ignore it, this is provided in attached patch.

Test case to reproduce the problem:

  1. Open modified Ajax sample attached
  2. Create editor and ensure focus is inside it
  3. Hit Hide
  4. Hit Show
  5. Put cursor into content area
  6. Repeat steps 3-5 until exception is thrown

Attachments (3)

6375.patch (434 bytes) - added by Damian 7 years ago.
Proposed fix
ajax.html (3.1 KB) - added by Damian 7 years ago.
Modified ajax sample to help reproduce the problem
6375_2.patch (605 bytes) - added by Frederico Caldeira Knabben 7 years ago.

Download all attachments as: .zip

Change History (7)

Changed 7 years ago by Damian

Attachment: 6375.patch added

Proposed fix

Changed 7 years ago by Damian

Attachment: ajax.html added

Modified ajax sample to help reproduce the problem

comment:1 Changed 7 years ago by Frederico Caldeira Knabben

Keywords: HasPatch added
Milestone: CKEditor 3.4.2
Owner: set to Frederico Caldeira Knabben
Status: newassigned

The patch looks good. It's just a matter of fixing the coding style and adding a comment pointing to this ticket to justify the fix.

Changed 7 years ago by Frederico Caldeira Knabben

Attachment: 6375_2.patch added

comment:2 Changed 7 years ago by Frederico Caldeira Knabben

Status: assignedreview

btw, please always create patch files from the editor root folder, so the full file path is included on it.

comment:3 Changed 7 years ago by Tobiasz Cudnik

Status: reviewreview_passed

comment:4 Changed 7 years ago by Frederico Caldeira Knabben

Resolution: fixed
Status: review_passedclosed

Fixed with [5918].

Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy