Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#6467 closed Bug (fixed)

setState(CKEDITOR.TRISTATE_DISABLED) on 'mode' impossible for maximize plugin

Reported by: Tony Owned by: Sa'ar Zac Elias
Priority: Normal Milestone: CKEditor 3.4.2
Component: UI : Toolbar Version: 3.4.1
Keywords: Cc:

Description

editor.on( 'mode', function() {
	if ( editor.mode == 'source' ) {
		editor.getCommand('maximize').setState(CKEDITOR.TRISTATE_DISABLED);
	}
});

Doesn't work as expected (I guess due to setState gymnastics going on in plugins/maximize/plugin.js) So this appears to make it impossible to disable the maximise plugin when switching to source view. It also reveals an inconsistency in CKEditor's API.

The above method works fine for 'newpage', 'preview', 'selectAll' but not maximize.

Attachments (1)

6467.patch (757 bytes) - added by Sa'ar Zac Elias 10 years ago.

Download all attachments as: .zip

Change History (6)

comment:1 Changed 10 years ago by Sa'ar Zac Elias

Status: newconfirmed

Changed 10 years ago by Sa'ar Zac Elias

Attachment: 6467.patch added

comment:2 Changed 10 years ago by Sa'ar Zac Elias

Component: GeneralUI : Toolbar
Milestone: CKEditor 3.4.2
Owner: set to Sa'ar Zac Elias
Status: confirmedreview

comment:3 Changed 10 years ago by Garry Yao

Status: reviewreview_passed

comment:4 Changed 10 years ago by Sa'ar Zac Elias

Resolution: fixed
Status: review_passedclosed

Fixed with [5940].

comment:5 Changed 10 years ago by Tony

Wow guys! Nice job.

Note: See TracTickets for help on using tickets.
© 2003 – 2020 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy