Opened 7 years ago

Closed 7 years ago

#6491 closed Bug (fixed)

The image lock ratio is set when the image URL field is populated.

Reported by: Joe Kavanagh Owned by: Garry Yao
Priority: Normal Milestone: CKEditor 3.5.3
Component: UI : Dialogs Version: 3.0
Keywords: IBM Cc: Damian

Description

  1. Open the image dialog.
  1. Click on the lock ratio icon to unlock it.
  1. Enter an image URL in the URL field.
  1. Press tab to remove focus from the URL field.

Observe that the lock ratio is automatically reset. You have to click it again to unlock the ratio before continuing.

The button should not be reset to 'locked' if the user explicitly set it to unlock. This behaviour could be confusing to a blind user. I am not sure why the URL field has an affect on the lock ratio button? I'm sure there was a valid reason.

Attachments (2)

6491.patch (699 bytes) - added by Garry Yao 7 years ago.
6491_2.patch (2.1 KB) - added by Garry Yao 7 years ago.

Download all attachments as: .zip

Change History (10)

Changed 7 years ago by Garry Yao

Attachment: 6491.patch added

comment:1 Changed 7 years ago by Garry Yao

Keywords: HasPatch added
Status: newconfirmed

comment:2 Changed 7 years ago by Sa'ar Zac Elias

Version: 3.5 (SVN - 3.5.x)3.0

comment:3 Changed 7 years ago by Garry Yao

Keywords: HasPatch removed
Owner: set to Garry Yao
Status: confirmedreview

comment:4 Changed 7 years ago by Wiktor Walc

Milestone: CKEditor 3.5.3

comment:5 Changed 7 years ago by Sa'ar Zac Elias

Status: reviewreview_passed

Changed 7 years ago by Garry Yao

Attachment: 6491_2.patch added

comment:6 Changed 7 years ago by Garry Yao

Status: review_passedreview

I've found the previous patch problematic as it doesn't restore lock ratio between dialog openings.

comment:7 Changed 7 years ago by Frederico Caldeira Knabben

Status: reviewreview_passed

comment:8 Changed 7 years ago by Garry Yao

Resolution: fixed
Status: review_passedclosed

Fixed with [6565].

Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy