Opened 8 years ago

Closed 8 years ago

#6522 closed Bug (fixed)

Simplification in indent plugin

Reported by: Alfonso Martínez de Lizarrondo Owned by: Alfonso Martínez de Lizarrondo
Priority: Normal Milestone: CKEditor 3.5.1
Component: General Version:
Keywords: Cc:

Description

I think that these changes are OK and avoid some extra calls by using the correct command object as the scope for the selectionchange listeners, but I would rather than someone could verify it.

Attachments (3)

6522.patch (2.9 KB) - added by Alfonso Martínez de Lizarrondo 8 years ago.
Proposed patch
6522_2.patch (5.6 KB) - added by Alfonso Martínez de Lizarrondo 8 years ago.
Updated with the list plugin that had the same issue
6522_3.patch (5.0 KB) - added by Alfonso Martínez de Lizarrondo 8 years ago.
Updated for trunk

Download all attachments as: .zip

Change History (8)

Changed 8 years ago by Alfonso Martínez de Lizarrondo

Attachment: 6522.patch added

Proposed patch

comment:1 Changed 8 years ago by Alfonso Martínez de Lizarrondo

Status: newreview

Changed 8 years ago by Alfonso Martínez de Lizarrondo

Attachment: 6522_2.patch added

Updated with the list plugin that had the same issue

comment:2 Changed 8 years ago by Wiktor Walc

Milestone: CKEditor 3.5.1

comment:3 Changed 8 years ago by Sa'ar Zac Elias

Update the patch please Alfonso.

Changed 8 years ago by Alfonso Martínez de Lizarrondo

Attachment: 6522_3.patch added

Updated for trunk

comment:4 Changed 8 years ago by Sa'ar Zac Elias

Status: reviewreview_passed

comment:5 Changed 8 years ago by Alfonso Martínez de Lizarrondo

Resolution: fixed
Status: review_passedclosed

Fixed with [6286]

I haven't added an entry in the changelog as it doesn't change any behavior and people shouldn't notice anything.

Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy