Opened 7 years ago

Closed 7 years ago

#6628 closed Bug (fixed)

Setting config.enterMode from PHP fails

Reported by: Gilles van den Hoven Owned by:
Priority: Normal Milestone: CKEditor 3.5.1
Component: Server : PHP Version: 3.1
Keywords: HasPatch Cc: gilles@…, d.czepierga@…

Description

Using this code fails;

[php] $this->configenterMode? = 'CKEDITOR.ENTER_BR'; $this->configshiftEnterMode? = 'CKEDITOR.ENTER_P'; php

However, setting thesame in the config.js works. Tested with PHP5 class, but problem exists in PHP4 class also i think..

Attachments (1)

#6628_ticket.patch (1.2 KB) - added by Damian 7 years ago.
Patch for ticket #6628

Download all attachments as: .zip

Change History (9)

comment:1 Changed 7 years ago by Gilles van den Hoven

This should read

$this->config['enterMode'] = 'CKEDITOR.ENTER_BR'; $this->config['shiftEnterMode'] = 'CKEDITOR.ENTER_P';

comment:2 Changed 7 years ago by Gilles van den Hoven

Proposed FIX: In the function "private function jsEncode($val)"

Replace:

$val = str_replace($jsonReplaces[0], $jsonReplaces[1], $val); return '"' . $val . '"';

With:

$val = str_replace($jsonReplaces[0], $jsonReplaces[1], $val); if (strtoupper(substr($val, 0, 9)) == 'CKEDITOR.') return $val; return '"' . $val . '"';

comment:3 Changed 7 years ago by Gilles van den Hoven

Cc: gilles@… added

comment:4 Changed 7 years ago by Frederico Caldeira Knabben

Keywords: HasPatch added
Milestone: CKEditor 3.6
Status: newconfirmed

Interesting approach for it.

comment:5 Changed 7 years ago by Wiktor Walc

Milestone: CKEditor 3.6CKEditor 3.5.1

Changed 7 years ago by Damian

Attachment: #6628_ticket.patch added

Patch for ticket #6628

comment:6 Changed 7 years ago by Damian

Cc: d.czepierga@… added
Version: 3.5.1 (SVN - trunk)

I check FIX made by Webunity and make patch for PHP5 and PHP4. I test it on both version of PHP and everything seems to work.

comment:7 Changed 7 years ago by Wiktor Walc

Version: 3.5.1 (SVN - trunk)3.1

comment:8 Changed 7 years ago by Wiktor Walc

Resolution: fixed
Status: confirmedclosed

Fixed with [6282].

Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy