Opened 10 years ago

Closed 10 years ago

#6684 closed Bug (fixed)

Toolbar isn't wrapped in Webkit when editor is in the table

Reported by: kresimir Owned by: Garry Yao
Priority: Normal Milestone: CKEditor 3.5.1
Component: UI : Toolbar Version: 3.0
Keywords: WebKit Cc:

Description

When toolbar has many items (e.g. Full toolbar) and editor is placed in table which is in div block with fixed width, editor doesn't wrap toolbar in WebKit (Chrome and Safari) and puts whole toolbar in one line.

To reproduce this bug, add following around a form which has editor with full toolbar:

<div style="width: 400px; border: 1px solid red;"><table><tr><td>
</div>

Attachments (3)

jqueryadapter_table.html (3.1 KB) - added by kresimir 10 years ago.
Reproducing the bug with modifying ckeditor/_samples/jqueryadapter.html
6684.patch (1.0 KB) - added by Garry Yao 10 years ago.
6684_2.patch (1.5 KB) - added by Garry Yao 10 years ago.

Download all attachments as: .zip

Change History (11)

Changed 10 years ago by kresimir

Attachment: jqueryadapter_table.html added

Reproducing the bug with modifying ckeditor/_samples/jqueryadapter.html

Changed 10 years ago by Garry Yao

Attachment: 6684.patch added

comment:1 Changed 10 years ago by Garry Yao

Component: GeneralUI : Toolbar
Milestone: CKEditor 3.5.1
Owner: set to Garry Yao
Status: newreview
Version: 3.0

Look serious, unless we come with a reason to keep that line.

comment:2 Changed 10 years ago by Tobiasz Cudnik

Keywords: WebKit added

comment:3 Changed 10 years ago by Tobiasz Cudnik

Works good, but i'm not sure if we should remove inline-table for all browsers, when it creates issue only on Webkit.

Changed 10 years ago by Garry Yao

Attachment: 6684_2.patch added

comment:4 Changed 10 years ago by Garry Yao

I've failed to check the original commits due the "lost" of the original kama branch, so please somebody remembers.

comment:5 Changed 10 years ago by Sa'ar Zac Elias

Status: reviewreview_failed

In Chrome, clicking on collapse toolbar button, the width of the editor decreases.

comment:6 in reply to:  5 Changed 10 years ago by Garry Yao

Status: review_failedreview

Replying to Saare:

In Chrome, clicking on collapse toolbar button, the width of the editor decreases.

Quite unfortunate but AFAIK that's an existing bug.

comment:7 Changed 10 years ago by Sa'ar Zac Elias

Status: reviewreview_passed

Indeed an existing bug, my bad.

comment:8 Changed 10 years ago by Garry Yao

Resolution: fixed
Status: review_passedclosed

Fixed with [6304].

Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy