Opened 7 years ago

Closed 6 years ago

#6718 closed Bug (fixed)

paste from word command should dominate

Reported by: Garry Yao Owned by: Garry Yao
Priority: Normal Milestone: CKEditor 3.5.4
Component: Core : Pasting Version: 3.1
Keywords: Cc: Thomas@…

Description

  1. Configure the editor with "forcePasteAsPlainText" set to true;
  2. Paste content from MS Word document with "Paste from Word" button;
  • Actual Result: Plain text are inserted;
  • Expected Result: Formatted text with proper word filtering are inserted.

Attachments (3)

6718.patch (652 bytes) - added by Garry Yao 7 years ago.
6718_2.patch (1.2 KB) - added by Garry Yao 7 years ago.
6718_3.patch (4.5 KB) - added by Garry Yao 6 years ago.

Download all attachments as: .zip

Change History (13)

Changed 7 years ago by Garry Yao

Attachment: 6718.patch added

comment:1 Changed 7 years ago by Garry Yao

Owner: set to Garry Yao
Status: newreview

comment:2 Changed 7 years ago by Frederico Caldeira Knabben

Milestone: CKEditor 3.5.1CKEditor 3.6

Being this a change on the behavior, I'm moving it to the 3.6.

We also need this exception documented on forcePasteAsPlainText, so people will be aware of it, not expecting plain text to be forced for the Paste from Word button as well.

comment:3 Changed 7 years ago by Frederico Caldeira Knabben

Status: reviewreview_failed

R- just for the missing documentation. I didn't check the code itself.

Changed 7 years ago by Garry Yao

Attachment: 6718_2.patch added

comment:4 Changed 7 years ago by Garry Yao

Status: review_failedreview

comment:5 Changed 6 years ago by Frederico Caldeira Knabben

Status: reviewreview_failed

The patch forces the usage of the Paste dialog even when not needed, which is an unwanted behavior.

The Past from Word processing must happen in the exact same way, no matter the forcePasteAsPlainText setting.

Changed 6 years ago by Garry Yao

Attachment: 6718_3.patch added

comment:6 Changed 6 years ago by Garry Yao

Status: review_failedreview

comment:7 Changed 6 years ago by Sa'ar Zac Elias

Status: reviewreview_failed

Pasting document from Word using CTRL+V (not the button) is still affected by forcePasteAsPlainText.

comment:8 in reply to:  7 Changed 6 years ago by Frederico Caldeira Knabben

Replying to Saare:

Pasting document from Word using CTRL+V (not the button) is still affected by forcePasteAsPlainText.

This behavior is ok Saare. This ticket is talking about the explicit action of using the Paste from Word button (or it's command).

Please put it on review again, Garry.

comment:9 Changed 6 years ago by Sa'ar Zac Elias

Status: review_failedreview_passed

Sorry, I was unaware of that. Patch is good than.

comment:10 Changed 6 years ago by Garry Yao

Milestone: CKEditor 3.6CKEditor 3.5.4
Resolution: fixed
Status: review_passedclosed

Fixed with [6678] on trunk.

Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy