Opened 14 years ago
Closed 14 years ago
#6728 closed Bug (fixed)
BIDI: BiDi buttons do not work on a list that is inside a blockquote
Reported by: | James | Owned by: | Garry Yao |
---|---|---|---|
Priority: | Normal | Milestone: | CKEditor 3.5.1 |
Component: | Core : BiDi | Version: | 3.4.2 |
Keywords: | IBM | Cc: | Damian, joek, Satya Minnekanti |
Description
Steps to reproduce the defect:
- Open the Ajax sample.
- Create a Numbered List.
- Select the Numbered List & click the RTL icon.
- Select the list & click Blockquote.
- Click on the LTR icon.
Expected: LTR language direction is applied to the Numbered List. The list appears on the left of the editor. The List is inside a Blockquote.
Actual: Nothing happens. The list remains RTL.
Attachments (7)
Change History (24)
comment:1 Changed 14 years ago by
Milestone: | → CKEditor 3.5.1 |
---|---|
Status: | new → confirmed |
comment:2 Changed 14 years ago by
Owner: | set to Tobiasz Cudnik |
---|---|
Status: | confirmed → assigned |
Changed 14 years ago by
Attachment: | 6728.patch added |
---|
comment:3 Changed 14 years ago by
Status: | assigned → review |
---|
Changed 14 years ago by
Attachment: | 6728_2.patch added |
---|
comment:4 Changed 14 years ago by
Status: | review → review_failed |
---|
comment:5 follow-up: 8 Changed 14 years ago by
Status: | review_failed → review |
---|
This is yet another case of the "apply to parent when all children selected" from BiDi cases, which is a feature.
Check this TC:
<blockquote> <p> a</p> <ul> [<li> 1</li> <li> 2</li> <li> 3</li>] </ul> <p> b</p> </blockquote>
Changed 14 years ago by
Attachment: | 6728_3.patch added |
---|
comment:7 Changed 14 years ago by
Status: | review → review_failed |
---|
6728_3.patch doesn't work for the original TC.
comment:8 Changed 14 years ago by
Replying to tobiasz.cudnik:
This is yet another case of the "apply to parent when all children selected" from BiDi cases, which is a feature.
Check this TC:
<blockquote> <p> a</p> <ul> [<li> 1</li> <li> 2</li> <li> 3</li>] </ul> <p> b</p> </blockquote>
I don't get the point, how does 6728_2.patch fail for the patch?
Changed 14 years ago by
Attachment: | 6728_4.patch added |
---|
comment:9 Changed 14 years ago by
Status: | review_failed → review |
---|
Please ignore my previous TC. 6728_2.patch also doesn't work with current trunk, but even if it would we can't accept such change because of this TC.
I'm sending new approach which fixes the problem with a quite small change.
comment:10 Changed 14 years ago by
Status: | review → review_failed |
---|
6728_4.patch indeed covers a bug, while having no benefit to the ticket bug itself, I still insist on applying dir on the innermost block limit, as that's the easiest way to avoid further bugs caused by differential direction on nested block limits.
Regard your cited TC, I think we could safely remove "tr" from guard elements.
Changed 14 years ago by
Attachment: | 6728_5.patch added |
---|
comment:11 Changed 14 years ago by
Owner: | changed from Tobiasz Cudnik to Garry Yao |
---|---|
Status: | review_failed → review |
comment:12 Changed 14 years ago by
Status: | review → review_failed |
---|
Using the following content and selection:
<table border="1" cellpadding="1" cellspacing="1" style="width: 500px;"> <tbody> <tr> [<td> aa</td> <td> bb</td>] </tr> <tr> <td> </td> <td> </td> </tr> <tr> <td> </td> <td> </td> </tr> </tbody> </table>
Click on RTL icon. Note that only the first cell of the two selected is in RTL.
comment:13 Changed 14 years ago by
Status: | review_failed → review |
---|
@Saar, the above cited TC is a bug of the domiterator reported with [6324], new patch covers it.
Changed 14 years ago by
Attachment: | 6728_6.patch added |
---|
comment:14 Changed 14 years ago by
Status: | review → review_failed |
---|
- Start with the following content and selection:
<table border="1" cellpadding="1" cellspacing="1" style="width: 500px;"> <tbody> <tr> [<td dir="rtl"> a</td> <td dir="rtl"> b</td> </tr> <tr> <td> </td> <td> </td>] </tr> </tbody> </table>
- Click on LTR button.
Note that the table is corrupted.
Changed 14 years ago by
Attachment: | 6728_7.patch added |
---|
comment:15 Changed 14 years ago by
Status: | review_failed → review |
---|
Nice catch, but yet another bug from domiterator.
comment:16 Changed 14 years ago by
Status: | review → review_passed |
---|
comment:17 Changed 14 years ago by
Resolution: | → fixed |
---|---|
Status: | review_passed → closed |
Fixed with [6333].
I think we simply apply the direction on the inner most block container (guard elements), in this case when user would like to instead apply it on an outer container, e.g. in this case he want to apply it to "blockquote", he can achieve that with the elements path bar (by first click on the blockquote button).