Ticket #6733 (closed Bug: fixed)

Opened 3 years ago

Last modified 3 years ago

Text Alignment toolbar tooltips incorrectly use "justify" to mean "align"

Reported by: Anna Owned by:
Priority: Normal Milestone: CKEditor 3.5
Component: UI : Language Version:
Keywords: Cc:

Description

The Text Alignment buttons incorrectly use the term "justify" to mean "align". Text justification means that the text spans from one margin to another without any ragging on any side. Our "Left/Right/Center Justify" functions, however, create a text that is ragged from one or both sides and thus NOT justified, but aligned.

Moreover, "left/right/center justify" are established terms that describe what happens with the last, incomplete line of the justified text, so CKEditor uses them in an entirely incorrect meaning.

I suggest we start with correcting the toolbar tooltips to stop confusing the end users with descriptions that do not match either what the function does or what its button shows.

Proposed changes:
Left Justify -> Align Left
Center Justify -> Center
Right Justify -> Align Right
Block Justify -> Justify

Attachments

6733.patch (471 bytes) - added by Anna 3 years ago.
Patch with correct tooltips

Change History

comment:1 Changed 3 years ago by wwalc

  • Status changed from new to confirmed
  • Component changed from UI : Toolbar to UI : Language
  • Milestone set to CKEditor 3.5

Changed 3 years ago by Anna

Patch with correct tooltips

comment:2 Changed 3 years ago by garry.yao

  • Status changed from confirmed to closed
  • Resolution set to fixed

Fixed with [6130].

comment:3 Changed 3 years ago by fredck

  • Status changed from closed to reopened
  • Resolution fixed deleted

The same must be done with the other English language file.

comment:4 Changed 3 years ago by fredck

Also, this ticket is targeted (correctly) to the 3.5, and the code has been committed on trunk.

comment:5 Changed 3 years ago by Saare

  • Status changed from reopened to closed
  • Resolution set to fixed

Reverted [6130] with [6133], fixed with [6134].

Note: See TracTickets for help on using tickets.
© 2003 – 2012 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy