Opened 7 years ago

Closed 7 years ago

#6733 closed Bug (fixed)

Text Alignment toolbar tooltips incorrectly use "justify" to mean "align"

Reported by: Anna Tomanek Owned by:
Priority: Normal Milestone: CKEditor 3.5
Component: UI : Language Version:
Keywords: Cc:

Description

The Text Alignment buttons incorrectly use the term "justify" to mean "align". Text justification means that the text spans from one margin to another without any ragging on any side. Our "Left/Right/Center Justify" functions, however, create a text that is ragged from one or both sides and thus NOT justified, but aligned.

Moreover, "left/right/center justify" are established terms that describe what happens with the last, incomplete line of the justified text, so CKEditor uses them in an entirely incorrect meaning.

I suggest we start with correcting the toolbar tooltips to stop confusing the end users with descriptions that do not match either what the function does or what its button shows.

Proposed changes:
Left Justify -> Align Left
Center Justify -> Center
Right Justify -> Align Right
Block Justify -> Justify

Attachments (1)

6733.patch (471 bytes) - added by Anna Tomanek 7 years ago.
Patch with correct tooltips

Download all attachments as: .zip

Change History (6)

comment:1 Changed 7 years ago by Wiktor Walc

Component: UI : ToolbarUI : Language
Milestone: CKEditor 3.5
Status: newconfirmed

Changed 7 years ago by Anna Tomanek

Attachment: 6733.patch added

Patch with correct tooltips

comment:2 Changed 7 years ago by Garry Yao

Resolution: fixed
Status: confirmedclosed

Fixed with [6130].

comment:3 Changed 7 years ago by Frederico Caldeira Knabben

Resolution: fixed
Status: closedreopened

The same must be done with the other English language file.

comment:4 Changed 7 years ago by Frederico Caldeira Knabben

Also, this ticket is targeted (correctly) to the 3.5, and the code has been committed on trunk.

comment:5 Changed 7 years ago by Sa'ar Zac Elias

Resolution: fixed
Status: reopenedclosed

Reverted [6130] with [6133], fixed with [6134].

Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy