Format Combo doesn't respect config.format_xx definitions

[Seb Duggan]

The format combo box doesn't display its options in the correct style as attributed in the config.format_xx options.

For example, if I set the following config option:

CKEDITOR.config.format_h1 = { element : 'h2'};

...then when I choose "Heading 1" from the combo, the selected text is formatted as an <h2> element. However, the format combo box still shows "Heading 1" with the <h1> CSS applied to it.

The fix for this is simple. In /_source/plugins/format/plugin.js, line 48 should be changed from:

this.add( tag, '<' + tag + '>' + label + '</' + tag + '>', label );

to:

this.add( tag, '<' + styles[tag].element + '>' + label + '</' + styles[tag].element + '>', label );

(You may like to do this differently according to house coding conventions).

[Sa'ar Zac Elias]

We should also support attributes and styles defined that way.

[Wiktor Walc]

This change may have a surprising results for some users, so targeting to 3.6.

[Garry Yao]

Patch unifies the styles definition of format combo with editor's standard styles definition (via styles set).

[Garry Yao]

Note that though back-compat on configuration (old format_tags) is not maintained by the propose patch, old editor wouldn't be broken because of upgrading.

[Frederico Caldeira Knabben]

I'm sorry to say so, but we don't need to make such a strong change to our code to achieve what the reported looks for here. We don't need another Style combo here, not even additional js files to get downloaded. The format combo has a precise and delimited scope. The solution is in fact as simple as proposed by the reporter.

KISS!

[Frederico Caldeira Knabben]

Fixed with [6683].