Opened 8 years ago

Last modified 7 years ago

#6749 review New Feature

Foreground or Background color not saved for a next usage

Reported by: fournaise Owned by: Alfonso Martínez de Lizarrondo
Priority: Normal Milestone:
Component: General Version: 3.0
Keywords: Cc:

Description

When you pick a color for the background or for text, this seleted color is saved for a next usage. This behavior is for instance implemented in MS word. The default color or the last used color is visible in the combobox, and you have only to click on the color; if you want to change the color you have to click on the arrow and selected a new one.

Attachments (2)

6749.patch (12.5 KB) - added by Alfonso Martínez de Lizarrondo 7 years ago.
Proposed patch
6749_2.patch (14.9 KB) - added by Alfonso Martínez de Lizarrondo 7 years ago.
Improved patch

Download all attachments as: .zip

Change History (11)

comment:1 Changed 8 years ago by Krzysztof Studnik

Version: 3.5 (SVN - 3.5.x)3.0

comment:2 Changed 8 years ago by Krzysztof Studnik

#7242 is DUP

comment:3 Changed 7 years ago by Jakub Ś

#8408 is a DUP.

It also mentions that the same feature should be applied to More Colors dialog.

comment:4 Changed 7 years ago by Jakub Ś

Status: newconfirmed

comment:5 Changed 7 years ago by Jakub Ś

This ticket is related to #8679

I think the ideal solution here would be making CKEditor behave like MS Word.

comment:6 Changed 7 years ago by Jakub Ś

I have also noticed that #8523 is related.

comment:7 Changed 7 years ago by Jakub Ś

#5960 is also related.

Changed 7 years ago by Alfonso Martínez de Lizarrondo

Attachment: 6749.patch added

Proposed patch

comment:8 Changed 7 years ago by Alfonso Martínez de Lizarrondo

Owner: set to Alfonso Martínez de Lizarrondo
Status: confirmedreview

The patch implements a color preview in the foreground and background colors. It also allows to know if the click on the toolbar is on the button or on the arrow and so it only shows the pane when there's no listener set for the button or the user presses the arrow.

And in the color plugin now reapplies the last selected color with just one click.

Changed 7 years ago by Alfonso Martínez de Lizarrondo

Attachment: 6749_2.patch added

Improved patch

comment:9 Changed 7 years ago by Alfonso Martínez de Lizarrondo

The new patch improves the styling of the buttons and adds also one-click to the SCAYT plugin.

Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy