Opened 7 years ago

Closed 7 years ago

#6753 closed Bug (fixed)

Cleanup core/editor class

Reported by: Frederico Caldeira Knabben Owned by: Garry Yao
Priority: Normal Milestone: CKEditor 3.5.1
Component: General Version: 3.3
Keywords: Cc:

Description (last modified by Frederico Caldeira Knabben)

I can't believe it has been accepted, but plugin and theme dependent code has landed into the CKEDITOR.editor class with [5231].

Not even a single line that has been included there is acceptable. That code must be moved to the proper place.

Attachments (1)

6753.patch (3.9 KB) - added by Garry Yao 7 years ago.

Download all attachments as: .zip

Change History (6)

Changed 7 years ago by Garry Yao

Attachment: 6753.patch added

comment:1 Changed 7 years ago by Garry Yao

Owner: set to Garry Yao
Status: newreview

Assuming you mean [5231].

comment:2 Changed 7 years ago by Tobiasz Cudnik

It look like R+ for me, but the code referenced in contextmenu is missing in current trunk. Does this change anything?

comment:3 Changed 7 years ago by Frederico Caldeira Knabben

Description: modified (diff)

comment:4 in reply to:  2 Changed 7 years ago by Sa'ar Zac Elias

Status: reviewreview_passed

Replying to tobiasz.cudnik:

the code referenced in contextmenu is missing in current trunk.

The piece of code you're refering to was removed with [5937] and it is no longer in any use.

comment:5 Changed 7 years ago by Garry Yao

Resolution: fixed
Status: review_passedclosed

Fixed with [6307].

Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy