Opened 15 years ago
Closed 15 years ago
#6753 closed Bug (fixed)
Cleanup core/editor class
| Reported by: | Frederico Caldeira Knabben | Owned by: | Garry Yao |
|---|---|---|---|
| Priority: | Normal | Milestone: | CKEditor 3.5.1 |
| Component: | General | Version: | 3.3 |
| Keywords: | Cc: |
Description (last modified by )
I can't believe it has been accepted, but plugin and theme dependent code has landed into the CKEDITOR.editor class with [5231].
Not even a single line that has been included there is acceptable. That code must be moved to the proper place.
Attachments (1)
Change History (6)
Changed 15 years ago by
| Attachment: | 6753.patch added |
|---|
comment:1 Changed 15 years ago by
| Owner: | set to Garry Yao |
|---|---|
| Status: | new → review |
comment:2 follow-up: 4 Changed 15 years ago by
It look like R+ for me, but the code referenced in contextmenu is missing in current trunk. Does this change anything?
comment:3 Changed 15 years ago by
| Description: | modified (diff) |
|---|
comment:4 Changed 15 years ago by
| Status: | review → review_passed |
|---|
Replying to tobiasz.cudnik:
the code referenced in contextmenu is missing in current trunk.
The piece of code you're refering to was removed with [5937] and it is no longer in any use.
comment:5 Changed 15 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | review_passed → closed |
Fixed with [6307].
Note: See
TracTickets for help on using
tickets.
Assuming you mean [5231].