Opened 9 years ago

Last modified 8 years ago

#6803 confirmed Bug

Image dialog error with border of zero

Reported by: pircio Owned by:
Priority: Normal Milestone:
Component: UI : Dialogs Version: 3.0.2
Keywords: HasPatch Cc: contact@…

Description

If you set the border property to zero (meaning no border) for an image in the image dialog, it will not save this value. This has been ongoing for as long as I can remember with the new CKeditor.

this is a hack fix for plugins/image/dialog/image.js:817

if ( type == IMAGE )
{
var value,
	borderStyle = element.getStyle( 'border-width' );
borderStyle = borderStyle && borderStyle.match( /^(\d+px)(?: \1 \1 \1)?$/ );
value = borderStyle && parseInt( borderStyle[ 1 ], 10 );
isNaN ( parseInt( value, 10 ) ) && ( value = element.getAttribute( 'border' ) );
//this.setValue( value );
if (value == 0)
{
   this.setValue('0');
}
else
{
   this.setValue(value);
}
}

Change History (2)

comment:1 Changed 8 years ago by Krzysztof Studnik

Keywords: HasPatch? added
Status: newconfirmed

comment:2 Changed 8 years ago by Sa'ar Zac Elias

Cc: contact@… added
Keywords: HasPatch added; HasPatch? removed
Version: 3.4.23.0.2
Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy