Opened 10 years ago

Closed 10 years ago

#6924 closed Task (fixed)

Visual improvements in samples provided with CKEditor

Reported by: Wiktor Walc Owned by: Wiktor Walc
Priority: Normal Milestone: CKEditor 3.5.1
Component: General Version: 3.0
Keywords: Cc: Anna Tomanek

Description

The current set of samples look quite poor. It would be nice to improve the styles a little bit and add some short description to each sample.

Attachments (3)

6924.patch (59.2 KB) - added by Wiktor Walc 10 years ago.
6924_2.patch (79.5 KB) - added by Wiktor Walc 10 years ago.
6924_3.patch (88.1 KB) - added by Wiktor Walc 10 years ago.

Download all attachments as: .zip

Change History (9)

Changed 10 years ago by Wiktor Walc

Attachment: 6924.patch added

comment:1 Changed 10 years ago by Wiktor Walc

Cc: Anna Tomanek added
Owner: set to Wiktor Walc
Status: newreview

comment:2 Changed 10 years ago by Garry Yao

Status: reviewreview_failed

Depending on how far we'd like to improve over this, an integrated sample list select right on the page like we have for v2 would be great.

Changed 10 years ago by Wiktor Walc

Attachment: 6924_2.patch added

comment:3 Changed 10 years ago by Wiktor Walc

Status: review_failedreview

Let's keep just a list of samples on a single HTML file. Some users may have problem with checking the source code of a sample loaded with select combo.

comment:4 Changed 10 years ago by Garry Yao

Status: reviewreview_passed

comment:5 Changed 10 years ago by Anna Tomanek

Minor and hopefully final improvements in HTML and PHP samples attached.

Changed 10 years ago by Wiktor Walc

Attachment: 6924_3.patch added

comment:6 Changed 10 years ago by Wiktor Walc

Resolution: fixed
Status: review_passedclosed

Fixed with [6336] using the patch provided by Anna with few minor adjustments.

Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy