Opened 12 years ago

Closed 12 years ago

Last modified 12 years ago

#695 closed Bug (fixed)

Wrong single quote entity code?

Reported by: plabadie@… Owned by: Michael Osipov
Priority: Normal Milestone: FCKeditor.Java 2.4
Component: Server : Java Version: FCKeditor 2.5.1
Keywords: SF Cc: simo@…

Description

In the class FCKeditor.java there is a metho HTMLEncode that is used to encode the initial text to be put in the editor upon display.

The straight single quote ' is encoded with entity '

However, in the java code, it is encoded with the entity ’ which is a ’ right side quote.

This does not cause only esthetic syntax chanfge. This causes FCKeditor's own generated Javascript code to fail. ( for example when you make a link that is to be opened in a popup ).

1) You save you popup link. Its ok. 2) You re-edit your popup link ( passes through HTMLEncode to be set as the initial text ). 3) You find out in the html source of the editor that the ' are tranformed in ’. Your text is corrupted.


Moved from SF:
http://sourceforge.net/tracker/index.php?func=detail&aid=1404166&group_id=75348&atid=543653

Change History (11)

comment:1 Changed 12 years ago by Martin Kou

Cc: simo@… added
Reporter: changed from Martin Kou to plabadie@…

Thank you this bug has already been pointed out and a fixed version will be released soon.

Simone


Moved from SF. Original poster: simo

comment:2 Changed 12 years ago by Alfonso Martínez de Lizarrondo

Component: GeneralServer : Java
Owner: set to alka13

#724 has been marked as dup

Has this bug been fixed in the java package? the bugs in sourceforge are quite old.

comment:3 Changed 12 years ago by Alfonso Martínez de Lizarrondo

#695 has been marked as dup

comment:4 in reply to:  3 Changed 12 years ago by Frederico Caldeira Knabben

Replying to alfonsoml:

#695 has been marked as dup

You meant, #757 has been marked as DUP ;)

comment:5 Changed 12 years ago by Frederico Caldeira Knabben

Owner: alka13 deleted

comment:6 Changed 12 years ago by Michael Osipov

Owner: set to Michael Osipov

I will investiage that!

comment:7 Changed 12 years ago by Michael Osipov

Status: newassigned

confirmed in Branch 2.4

comment:8 in reply to:  7 Changed 12 years ago by Michael Osipov

Replying to mosipov:

confirmed in Branch 2.4

wrong entity is described here

comment:9 Changed 12 years ago by Michael Osipov

Milestone: FCKeditor.Java 2.4
Resolution: fixed
Status: assignedclosed
Version: FCKeditor 2.5.1

Fixed in [1342] in FCKeditor#escapeXml according to this escaping symbols with Unicode codepoints now.

Works as expected, tested with

<FCK:editor id="EditorDefault">
Some simple ' hacks by Mike's <strong>abitions</strong> for &lt;, &gt; and " &#39;
</FCK:editor>

comment:10 Changed 12 years ago by Frederico Caldeira Knabben

It may sound a little bit late to say that, but is this entity conversion needed? I don't see problems on having single quotes in the generated source.

Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy