Opened 7 years ago

Closed 7 years ago

Last modified 6 years ago

#7114 closed Bug (fixed)

iframe plugin does not allow percentage widths

Reported by: effulgentsia Owned by: Sa'ar Zac Elias
Priority: Normal Milestone: CKEditor 3.6.1
Component: General Version: 3.5
Keywords: IBM Cc: monahant@…

Description (last modified by Krzysztof Studnik)

Using Mac Firefox 3.6, CKEditor 3.5.1,

  • add an IFRAME to the textarea with the new iframe plugin / toolbar button.
  • Try to add "100%" as the width.

result:An error message comes back saying only numbers are allowed.
I suspect related to this, if you already have existing text content that contains HTML that includes an iframe with "100%" width, enabling CKEditor on that textarea converts the width to "100". This is a regression from CKEditor 3.4 which left iframes alone (though did not allow selecting them to make changes).

For anyone wishing to disable the iframe plugin until this is fixed, you can add "iframe" to config.removePlugins when calling CKEDITOR.replace(element, config) (see http://docs.cksource.com/ckeditor_api/symbols/CKEDITOR.html#.replace and http://docs.cksource.com/ckeditor_api/symbols/CKEDITOR.config.html#.removePlugins).

Attachments (2)

7114.patch (6.3 KB) - added by Sa'ar Zac Elias 7 years ago.
7114_2.patch (8.7 KB) - added by Sa'ar Zac Elias 7 years ago.

Download all attachments as: .zip

Change History (9)

comment:1 Changed 7 years ago by Krzysztof Studnik

Description: modified (diff)
Status: newconfirmed
Version: 3.5.13.5

Confirmed for all browsers.
TC for second part of ticket:

  • add new iframe, width set to 100
  • in Source mode set its width to width="100%"
  • Switch back to WYSIWYG -> iframe is set to 100% width of edit area
  • Switch back to Source -> width is set back to 100

comment:2 Changed 7 years ago by Teresa Monahan

Cc: monahant@… added
Keywords: IBM added

comment:3 Changed 7 years ago by Sa'ar Zac Elias

Owner: set to Sa'ar Zac Elias
Status: confirmedassigned

Changed 7 years ago by Sa'ar Zac Elias

Attachment: 7114.patch added

comment:4 Changed 7 years ago by Sa'ar Zac Elias

Status: assignedreview

Changed 7 years ago by Sa'ar Zac Elias

Attachment: 7114_2.patch added

comment:5 Changed 7 years ago by Sa'ar Zac Elias

Proposing another layout, as per Anna's suggestions.

comment:6 Changed 7 years ago by Sa'ar Zac Elias

Milestone: CKEditor 3.6.1
Resolution: fixed
Status: reviewclosed

Fixed by #6462.

comment:7 Changed 6 years ago by Jesse Beach

This issue is related to #8586

Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy