Opened 6 years ago

Closed 6 years ago

#7294 closed Bug (fixed)

IE we can't convert Numbered list to a Bulleted list and vice versa

Reported by: Satya Minnekanti Owned by: Sa'ar Zac Elias
Priority: Normal Milestone: CKEditor 3.5.3
Component: General Version: 3.5.3
Keywords: IBM IE Cc: Damian, James Cunningham, Teresa Monahan

Description

To reproduce the defect

  1. Open CK Editor and type 2 paragraphs of text.
  1. select 2 paragraphs and click on Insert/Remove Numbered list button
  1. see that a Numbered list appears with 2 list items.
  1. Now select both list items and click on Insert/Remove Bulleted list button.

Expected Result:

Numbered list is converted to a Bulleted list.

Actual Result:

Nothing happens and we are seeing an error in IE and error says 'this.$currentStyle' is null or not an object.

same issue occurs when we try to convert a Bulleted list to a Numbered list.

Attachments (2)

7294.patch (795 bytes) - added by Sa'ar Zac Elias 6 years ago.
7294_2.patch (1.3 KB) - added by Sa'ar Zac Elias 6 years ago.

Download all attachments as: .zip

Change History (10)

comment:1 Changed 6 years ago by Sa'ar Zac Elias

Milestone: CKEditor 3.5.3
Status: newconfirmed
Version: 3.5.3 (SVN - trunk)

Regression of [6478].

Changed 6 years ago by Sa'ar Zac Elias

Attachment: 7294.patch added

comment:2 Changed 6 years ago by Sa'ar Zac Elias

Keywords: IE added
Owner: set to Sa'ar Zac Elias
Status: confirmedreview

IE will generate an error when getting current styles from elements that are yet to be in the DOM tree.

comment:3 Changed 6 years ago by Sa'ar Zac Elias

#7303 is a dup.

comment:4 Changed 6 years ago by Garry Yao

Status: reviewreview_failed

"currentStyle" is not a cross-browser property.

Changed 6 years ago by Sa'ar Zac Elias

Attachment: 7294_2.patch added

comment:5 Changed 6 years ago by Sa'ar Zac Elias

Status: review_failedreview

comment:6 Changed 6 years ago by Sa'ar Zac Elias

Seems like the problem affects non-IEs as well in a different way, the latest patch fixes issues described in #7320, #7319.

comment:7 Changed 6 years ago by Garry Yao

Status: reviewreview_passed

Instead of having "isInDoc( el, doc )" I think we could safely have "isOffline( el )".

comment:8 Changed 6 years ago by Sa'ar Zac Elias

Resolution: fixed
Status: review_passedclosed

Fixed with [6551].

Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy