Opened 9 years ago

Closed 9 years ago

#7351 closed Bug (fixed)

Image dialog: width/height must be a number

Reported by: Wiktor Walc Owned by: Sa'ar Zac Elias
Priority: Normal Milestone: CKEditor 3.5.3
Component: General Version: 3.5.3
Keywords: Cc:

Description

When inserting an image, width and height fields are optional.

However, when left empty, after pressing the "Ok" button, CKEditor shows two alert messages: "Width must be a number", "Height must be a number".

Introduced with [6555]. Confirmed at least in IE8. Note: "0" should not be allowed, but empty values should be still allowed.

Attachments (2)

7351.patch (1.4 KB) - added by Sa'ar Zac Elias 9 years ago.
7351_2.patch (1.7 KB) - added by Sa'ar Zac Elias 9 years ago.

Download all attachments as: .zip

Change History (6)

Changed 9 years ago by Sa'ar Zac Elias

Attachment: 7351.patch added

comment:1 Changed 9 years ago by Sa'ar Zac Elias

Owner: set to Sa'ar Zac Elias
Status: newreview

Changed 9 years ago by Sa'ar Zac Elias

Attachment: 7351_2.patch added

comment:2 Changed 9 years ago by Sa'ar Zac Elias

Patch updated according to [6589] (which is also missing the same fix for the height field).

comment:3 Changed 9 years ago by Garry Yao

Status: reviewreview_passed

comment:4 Changed 9 years ago by Sa'ar Zac Elias

Resolution: fixed
Status: review_passedclosed

Fixed with [6592].

Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy