Opened 8 years ago

Closed 5 years ago

#7422 closed Bug (duplicate)

Support drag&drop in Undo system

Reported by: Alfonso Martínez de Lizarrondo Owned by: Alfonso Martínez de Lizarrondo
Priority: Normal Milestone:
Component: Core : Undo & Redo Version:
Keywords: Cc: satya_minnekanti@…

Description

Drag&drop doesn't create Undo images, so they can't be restored correctly.

The patch fixes the problem (as best as I can).

In Firefox all the situations seems to be correct now. In IE8, drag&drop from external sources don't create the initial image. In Webkit the final image isn't created. Opera doesn't support Drag&drop

Attachments (3)

7422.patch (1.6 KB) - added by Alfonso Martínez de Lizarrondo 8 years ago.
Proposed patch
7422_2.patch (1.5 KB) - added by Garry Yao 8 years ago.
7422_3.patch (2.1 KB) - added by Alfonso Martínez de Lizarrondo 8 years ago.
Updated patch

Download all attachments as: .zip

Change History (10)

Changed 8 years ago by Alfonso Martínez de Lizarrondo

Attachment: 7422.patch added

Proposed patch

comment:1 Changed 8 years ago by Alfonso Martínez de Lizarrondo

Status: newreview

Filed https://bugs.webkit.org/show_bug.cgi?id=57185 for the Webkit problems

comment:2 Changed 8 years ago by Satya Minnekanti

Cc: satya_minnekanti@… added

Changed 8 years ago by Garry Yao

Attachment: 7422_2.patch added

comment:3 Changed 8 years ago by Garry Yao

Status: reviewreview_failed

Providing a simplified patch that handles:

  1. In-doc D&D for Safari;
  2. Support for from-outside D&D for IE;

Changed 8 years ago by Alfonso Martínez de Lizarrondo

Attachment: 7422_3.patch added

Updated patch

comment:4 Changed 8 years ago by Alfonso Martínez de Lizarrondo

Status: review_failedreview

The 7422_2 patch wasn't working for me with Firefox 3.6, so I've readjusted it using part of the original code and now it's working with IE8, Firefox 3.6 and Chrome 10. I'll test other browsers tomorrow to check if there's any unexpected issue.

comment:5 Changed 7 years ago by Jakub Ś

#6337 was marked as duplicate.

comment:6 Changed 6 years ago by Jakub Ś

#9987 was marked as duplicate.

comment:7 Changed 5 years ago by Piotrek Koszuliński

Resolution: duplicate
Status: reviewclosed

Will be handled in #11437.

Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy