Opened 7 years ago

Closed 6 years ago

#7639 closed Bug (fixed)

IE9: Browser crashes when inserting image links with different targets

Reported by: James Cunningham Owned by: Sa'ar Zac Elias
Priority: Normal Milestone: CKEditor 3.6.1
Component: General Version: 3.3.2
Keywords: IE9 IBM Cc: Damian, Satya Minnekanti, Teresa Monahan

Description

Steps to reproduce the defect:

  1. Open the Ajax sample in IE9.
  1. Open the image dialog.
  1. On the Image Info tab, Paste the following image into the URL field. http://a.cksource.com/e/1/img/logo-ckeditor-h100.png
  1. Click on the Link tab & paste the same URL into the URL field.
  1. Set the target to New Window (_blank) & click OK.
  1. See that the image is inserted into the editor.
  1. Right click on the image & open the image properties dialog.
  1. Click on the Link tab & change the target to Topmost Window (_top) & click OK.
  1. Click on Remove Editor.

Result: A message saying Internet Explorer has stopped working is displayed and the page closes

Attachments (3)

7639.patch (731 bytes) - added by Sa'ar Zac Elias 6 years ago.
7639_2.patch (639 bytes) - added by Garry Yao 6 years ago.
7639_3.patch (602 bytes) - added by Sa'ar Zac Elias 6 years ago.

Download all attachments as: .zip

Change History (13)

comment:1 Changed 6 years ago by Jakub Ś

Status: newconfirmed
Version: 3.5.4 (SVN - trunk)3.3.2

comment:2 Changed 6 years ago by Garry Yao

It looks to be related to the image selection state when remove editor (doesn't happen when first remove image selection from editor).

comment:3 Changed 6 years ago by Frederico Caldeira Knabben

Milestone: CKEditor 3.6.1

Changed 6 years ago by Sa'ar Zac Elias

Attachment: 7639.patch added

comment:4 Changed 6 years ago by Sa'ar Zac Elias

Owner: set to Sa'ar Zac Elias
Status: confirmedreview

Seems like cleaning the selection is enough to resolve the bug.

Changed 6 years ago by Garry Yao

Attachment: 7639_2.patch added

comment:5 Changed 6 years ago by Garry Yao

Status: reviewreview_failed

Let's keep the hack right now inside of the selection plugin.

comment:6 Changed 6 years ago by Garry Yao

Owner: changed from Sa'ar Zac Elias to Garry Yao
Status: review_failedreview

comment:7 Changed 6 years ago by Sa'ar Zac Elias

Status: reviewreview_failed

The new patch doesn't seem to help to resolve the bug.

Changed 6 years ago by Sa'ar Zac Elias

Attachment: 7639_3.patch added

comment:8 Changed 6 years ago by Sa'ar Zac Elias

Owner: changed from Garry Yao to Sa'ar Zac Elias
Status: review_failedreview

comment:9 Changed 6 years ago by Garry Yao

Status: reviewreview_passed

Perhaps I get some luck with my previous patch but ok...

comment:10 Changed 6 years ago by Sa'ar Zac Elias

Resolution: fixed
Status: review_passedclosed

Fixed with [6993].

Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy