Ticket #778 (closed Bug: fixed)

Opened 7 years ago

Last modified 6 years ago

.Net dialog upload not using Type attribute during save

Reported by: mufasa@… Owned by:
Priority: Normal Milestone: FCKeditor.Net 2.5
Component: Server : ASP.Net Version:
Keywords: SF Cc:

Description

I didn't have time to make a patch, but the ASP.NET upload mechanism does not utilize the (now default) file type attribute (Type=(Image|File|Flash|etc)) from the GET request during file upload.

Files uploaded via the dialog windows' (Image, Flash, etc.) Upload tab all get dumped into the root UserFiles directory. But all other code, including the Browse button on the same dialog window, only show the files in the individual sub directories.

In the meantime, I have disabled the Upload tabs from those dialogs to force my users to use the file Browser upload feature instead, which does use the type attribute properly.

The Type is passed via the HTTP request though already. All you have to do is just insert Request.QueryStringType? in between the path (this.UserFilesDirectory) and file name (sFileName) to the full path (sFilePath). This can probably be done around line 51 in Uploader.cs when the strings are Path.Combine()'d. (Some basic error checking should be added or course for missing or known-only parameters.)

I would do this myself and submit a patch but I don't have the full Visual Studio package and don't want to bother doing all the compiling manually.

(Version 2.3.1 and FCKeditor.NEt_2.2 on a Microsoft ASP.NET 2.0 platform. All browsers affected as it is a server-side issue.)


Moved from SF:
http://sourceforge.net/tracker/index.php?func=detail&aid=1565169&group_id=75348&atid=543653

Change History

comment:1 Changed 7 years ago by martinkou

  • Reporter changed from martinkou to mufasa@…

comment:2 Changed 7 years ago by alfonsoml

  • Component changed from General to Server : ASP.Net

comment:3 Changed 6 years ago by alfonsoml

  • Status changed from new to closed
  • Resolution set to fixed
  • Milestone set to FCKeditor.Net 2.5

This was corrected for FCKeditor.Net 2.5

Note: See TracTickets for help on using tickets.
© 2003 – 2012 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy