Opened 6 years ago

Closed 6 years ago

#7844 closed Bug (fixed)

FF: setData() on hidden editor causes editor not to display

Reported by: Damian Owned by: Sa'ar Zac Elias
Priority: Normal Milestone: CKEditor 3.6.1
Component: General Version: 3.4.1
Keywords: IBM Firefox Cc:

Description

This problem happens on FF and when the instance is created with CKEDITOR.appendTo().

When the editor's container is hidden and setData() is called on it, making the container visible does not make the editor instance visible.

The problem appears to be related to the following in wysiwygarea plugin.js:

if ( isHidden )
{
	setTimeout( function()
	{
		element.hide();
		element.setStyles( previousStyles );
	}, 1000 );
}

A sample test page has been attached also.

Attachments (3)

7844.html (1.5 KB) - added by Damian 6 years ago.
Test case
7844.patch (1.1 KB) - added by Sa'ar Zac Elias 6 years ago.
7844_5956.html (1.7 KB) - added by Sa'ar Zac Elias 6 years ago.

Download all attachments as: .zip

Change History (10)

Changed 6 years ago by Damian

Attachment: 7844.html added

Test case

comment:1 Changed 6 years ago by Jakub Ś

Keywords: Firefox added
Status: newconfirmed
Version: 3.5.23.4.1

True for Firefox browsers from CKEditor 3.4.1

Changed 6 years ago by Sa'ar Zac Elias

Attachment: 7844.patch added

comment:2 Changed 6 years ago by Sa'ar Zac Elias

Owner: set to Sa'ar Zac Elias
Status: confirmedreview

Seems like [5835] from #5956 is no longer needed.

comment:3 Changed 6 years ago by Damian

Has this patch been verified?

Changed 6 years ago by Sa'ar Zac Elias

Attachment: 7844_5956.html added

comment:4 Changed 6 years ago by Sa'ar Zac Elias

Attached is a TC for both this ticket and #5956.

comment:5 Changed 6 years ago by Frederico Caldeira Knabben

Status: reviewreview_passed

As for #5956, I've just tested it with Firefox 3.6.16 and it works well. I'm happy to remove that hack from the code.

comment:6 Changed 6 years ago by Frederico Caldeira Knabben

Milestone: CKEditor 3.6.1

comment:7 Changed 6 years ago by Sa'ar Zac Elias

Resolution: fixed
Status: review_passedclosed

Fixed with [6934].

Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy