Opened 13 years ago

Closed 13 years ago

Last modified 10 years ago

#7872 closed Bug (fixed)

two-level list pasted from word gets flattened or split

Reported by: Jakub Ś Owned by: Garry Yao
Priority: Normal Milestone: CKEditor 3.6.1
Component: Plugin : Paste from Word Version: 3.6.1
Keywords: Cc: satya_minnekanti@…

Description

  1. Paste one of the lists from the attached file
  2. It will get flattened or split

This has been happening probably from revision [6914]. It works in [6908]. Revisions [6909] - [6913] don't load CKEditor so the first not working version is [6914]

Attachments (2)

lists.doc (25.5 KB) - added by Jakub Ś 13 years ago.
7872.patch (5.3 KB) - added by Garry Yao 13 years ago.

Download all attachments as: .zip

Change History (15)

Changed 13 years ago by Jakub Ś

Attachment: lists.doc added

comment:1 Changed 13 years ago by Jakub Ś

Status: newconfirmed

comment:2 Changed 13 years ago by Satya Minnekanti

Cc: satya_minnekanti@… added

comment:3 Changed 13 years ago by Wiktor Walc

Milestone: CKEditor 3.6.1

comment:4 Changed 13 years ago by Garry Yao

Status: confirmedpending

In which browser do you have it? What's the pasting result of the output?

comment:5 Changed 13 years ago by Wiktor Walc

IE8 / Win 7
http://nightly.ckeditor.com/7007/_samples/ajax.html

Select the first list and paste it into CKEditor, results on my computer:

(trunk)

<ul>
	<li>
		item1
		<ol>
			<li>
				item11</li>
			<li>
				item12</li>
			<li>
				item13</li>
		</ol>
	</li>
</ul>

CKEditor 3.6

<ul>
	<li>
		item1
		<ol>
			<li>
				item11</li>
			<li>
				item12</li>
			<li>
				item13</li>
		</ol>
	</li>
	<li>
		item2</li>
	<li>
		item3</li>
</ul>

(the last two items are lost)

Select and copy the second list, the result is:

(trunk)

<ol>
	<li>
		item1</li>
	<li>
		item2</li>
</ol>
<ul>
	<li>
		item21</li>
	<li>
		item22</li>
	<li>
		item23
		<ol>
			<li value="3">
				item3</li>
			<li value="4">
				item4</li>
		</ol>
	</li>
</ul>
<ul>
	<li>
		item41</li>
	<li>
		item42</li>
</ul>

CKEditor 3.6:

<ol>
	<li>
		item1</li>
	<li>
		item2</li>
</ol>
<ul>
	<li>
		item21</li>
	<li>
		item22</li>
	<li>
		item23</li>
</ul>
<ol>
	<li value="3">
		item3</li>
	<li value="4">
		item4</li>
</ol>
<ul>
	<li>
		item41</li>
	<li>
		item42</li>
</ul>

item3 and item 4 are now indented.

Last edited 13 years ago by Wiktor Walc (previous) (diff)

comment:6 Changed 13 years ago by Wiktor Walc

Status: pendingconfirmed

comment:7 Changed 13 years ago by Garry Yao

Owner: set to Garry Yao
Status: confirmedassigned

comment:8 Changed 13 years ago by Garry Yao

Status: assignedreview

There's a logic whole in the list flatting logic which cause some list items lost.

Version 0, edited 13 years ago by Garry Yao (next)

Changed 13 years ago by Garry Yao

Attachment: 7872.patch added

comment:9 Changed 13 years ago by Jakub Ś

In revision [6914] the first list from the TC was flattened. Now the last item is removed from it.

About second list: I don't know and remember why I have placed it in that TC as it's a different issue. The second example worked till version 3.5.2 for all browsers except Firefox (3.6 and 4). From version 3.5.3 rev [6616] list gets split in all browsers (except FF3.6). I have created a ticket for the second example from TC.

comment:10 Changed 13 years ago by Jakub Ś

The ticket for the second example form TC is reported here #7982

comment:11 Changed 13 years ago by Sa'ar Zac Elias

Status: reviewreview_passed

comment:12 Changed 13 years ago by Garry Yao

Component: GeneralCore : Pasting
Resolution: fixed
Status: review_passedclosed

Fixed with [7008].

comment:13 Changed 10 years ago by Frederico Caldeira Knabben

Component: Core : PastingPlugin : Paste from Word
Note: See TracTickets for help on using tickets.
© 2003 – 2022, CKSource sp. z o.o. sp.k. All rights reserved. | Terms of use | Privacy policy