Opened 6 years ago

Last modified 6 years ago

#7886 review_failed Bug

Show border plugin + custom table dialog

Reported by: Garry Yao Owned by: Garry Yao
Priority: Normal Milestone:
Component: UI : Dialogs Version: 3.1
Keywords: Cc:

Description

The "showborders" makes assumption on existence of certain table dialog field thus get broken when table dialog definition is reduced.

Attachments (2)

7886.html (3.4 KB) - added by Garry Yao 6 years ago.
Reproducing sample page
7886.patch (3.9 KB) - added by Garry Yao 6 years ago.

Download all attachments as: .zip

Change History (4)

Changed 6 years ago by Garry Yao

Attachment: 7886.html added

Reproducing sample page

comment:1 Changed 6 years ago by Garry Yao

Owner: set to Garry Yao
Status: newreview

Changed 6 years ago by Garry Yao

Attachment: 7886.patch added

comment:2 Changed 6 years ago by Sa'ar Zac Elias

Status: reviewreview_failed

The patch needs to be updated. Also, while at it, let's consider CSS borders. (And a small enhancement: the bidi plugin contains isOffline method, let's change it as well if adding it to dom.element).

Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy