Opened 6 years ago

Closed 6 years ago

#7911 closed New Feature (fixed)

Unable to remove anchor

Reported by: RichardD Owned by: Sa'ar Zac Elias
Priority: Normal Milestone: CKEditor 3.6.1
Component: UI : Context Menu Version: 3.6
Keywords: Cc:

Description

In the FCKeditor, there was a context-menu option to remove an anchor. In the CKEditor, this option does not exist.

Attempting to remove the anchor by clearing the anchor name displays the error, "Please type the anchor name".

As a result, the only way to remove an anchor is to edit the source.

Attachments (2)

7911.patch (2.6 KB) - added by Sa'ar Zac Elias 6 years ago.
7911_2.patch (2.6 KB) - added by Sa'ar Zac Elias 6 years ago.

Download all attachments as: .zip

Change History (8)

comment:1 Changed 6 years ago by Frederico Caldeira Knabben

Keywords: remove anchor removed
Milestone: CKEditor 3.6.1
Status: newconfirmed

Up to CKEditor 3.6, it was possible to create collapsed anchors only, which were represented by icons only. To delete them, it was enough to simple delete those icons.

As we've added the ability to create anchors with contents, we're now in fact missing a way to remove them. Nice catch!

Changed 6 years ago by Sa'ar Zac Elias

Attachment: 7911.patch added

comment:2 Changed 6 years ago by Sa'ar Zac Elias

Owner: set to Sa'ar Zac Elias
Status: confirmedreview

comment:3 Changed 6 years ago by Frederico Caldeira Knabben

Status: reviewreview_failed

In Firefox, it's not possible to remove collapsed anchors.

Additionally, there is no need to use CKEDITOR.tools.extend() at line 161. It just makes the code bigger and more complicated. Simply assigning the "menu" object properties is enough.

Changed 6 years ago by Sa'ar Zac Elias

Attachment: 7911_2.patch added

comment:4 Changed 6 years ago by Sa'ar Zac Elias

Status: review_failedreview

comment:5 Changed 6 years ago by Frederico Caldeira Knabben

Status: reviewreview_passed
Type: BugNew Feature

comment:6 Changed 6 years ago by Sa'ar Zac Elias

Resolution: fixed
Status: review_passedclosed

Fixed with [6980].

Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy