Opened 10 years ago

Closed 10 years ago

#7914 closed Bug (fixed)

setReadOnly does the reverse of what it says it does

Reported by: Joe Owned by: Frederico Caldeira Knabben
Priority: Normal Milestone: CKEditor 3.6.1
Component: General Version: 3.6
Keywords: Cc:

Description

Descriptive summary :

According to http://ckeditor.com/blog/CKEditor_3.6_released , editor.setReadOnly( true ) should turn Read Only mode on, while editor.setReadOnly( false ) sould turn Read Only mode off. In practice, its switched.

Steps to reproduce :

  1. Go to http://nightly.ckeditor.com/6956/_samples/readonly.html in Chrome
  2. Right click inspect to get to your console window
  3. In the console, type: editor.setReadOnly( true )
  4. Verify that the editor is not in read only mode
  5. In the console, type: editor.setReadOnly( false )
  6. Verify that the editor is in read only mode

Browser name and OS :

Chrome, Windows XP

Screenshot :

Attachments (2)

2011-05-24_1621.png (97.0 KB) - added by Joe 10 years ago.
screenshot
7914.patch (2.2 KB) - added by Frederico Caldeira Knabben 10 years ago.

Download all attachments as: .zip

Change History (6)

Changed 10 years ago by Joe

Attachment: 2011-05-24_1621.png added

screenshot

comment:1 Changed 10 years ago by Frederico Caldeira Knabben

Owner: set to Frederico Caldeira Knabben
Status: newassigned

The fact is that the release page example is the way it *should* be... but unfortunately a counter-intuitive way for it landed on the case, were "true" makes it editable.

I know we should not do that, but in this case we need to fix the API signature to make it work on the naturally expected way.

Changed 10 years ago by Frederico Caldeira Knabben

Attachment: 7914.patch added

comment:2 Changed 10 years ago by Frederico Caldeira Knabben

Status: assignedreview

comment:3 Changed 10 years ago by Sa'ar Zac Elias

Milestone: CKEditor 3.6.1
Status: reviewreview_passed
Version: 3.6

Be sure to change the name of the parameter of the sample's toggleReadOnly function as well.

comment:4 Changed 10 years ago by Frederico Caldeira Knabben

Resolution: fixed
Status: review_passedclosed

Fixed with [6965].

Note: See TracTickets for help on using tickets.
© 2003 – 2020 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy