Opened 6 years ago

Closed 6 years ago

#7947 closed Bug (fixed)

Table dialog should not allow negative values for width,height,Cell Spacing & Cell Padding

Reported by: Satya Minnekanti Owned by: Sa'ar Zac Elias
Priority: Normal Milestone: CKEditor 3.6.1
Component: UI : Dialogs Version: 3.6.1
Keywords: IBM Cc: Damian, James Cunningham, Teresa Monahan

Description

To reproduce the defect:

  1. Open CK Editor and click on Table icon.
  1. In Table Properties dialog enter negative vales for width(-200), height(-300),cell spacing(-10) & cell padding(-5).
  1. Click OK button.

Expected Result: An error dialog comes up with a waring message "width must be a whole number greater than zero".

Actual Result: Table inserted with no values set for width & height,negative values shown for Cell Spacing & Cell Padding but they have no impact when we see the table in WYSIWYG mode.

Attachments (1)

7947.patch (704 bytes) - added by Sa'ar Zac Elias 6 years ago.

Download all attachments as: .zip

Change History (7)

comment:1 Changed 6 years ago by Jakub Ś

Status: newconfirmed

True from rev [6979]

comment:2 Changed 6 years ago by Jakub Ś

This revision has also caused ticket #7948

Changed 6 years ago by Sa'ar Zac Elias

Attachment: 7947.patch added

comment:3 Changed 6 years ago by Sa'ar Zac Elias

Owner: set to Sa'ar Zac Elias
Status: confirmedreview

comment:4 Changed 6 years ago by Garry Yao

Component: GeneralUI : Dialogs
Status: reviewreview_passed

It's ok, thought negative length is explicitly defined as valid for CSS, it's mostly useful in position style only (e.g. left,top) which doesn't affect our current dialog system yet, which could be handled later as special cases.

comment:5 Changed 6 years ago by Frederico Caldeira Knabben

Milestone: CKEditor 3.6.1

comment:6 Changed 6 years ago by Sa'ar Zac Elias

Resolution: fixed
Status: review_passedclosed

Fixed with [6994].

Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy