Opened 14 years ago
Closed 14 years ago
#7947 closed Bug (fixed)
Table dialog should not allow negative values for width,height,Cell Spacing & Cell Padding
Reported by: | Satya Minnekanti | Owned by: | Sa'ar Zac Elias |
---|---|---|---|
Priority: | Normal | Milestone: | CKEditor 3.6.1 |
Component: | UI : Dialogs | Version: | 3.6.1 |
Keywords: | IBM | Cc: | Damian, James Cunningham, Teresa Monahan |
Description
To reproduce the defect:
- Open CK Editor and click on Table icon.
- In Table Properties dialog enter negative vales for width(-200), height(-300),cell spacing(-10) & cell padding(-5).
- Click OK button.
Expected Result: An error dialog comes up with a waring message "width must be a whole number greater than zero".
Actual Result: Table inserted with no values set for width & height,negative values shown for Cell Spacing & Cell Padding but they have no impact when we see the table in WYSIWYG mode.
Attachments (1)
Change History (7)
comment:1 Changed 14 years ago by
Status: | new → confirmed |
---|
Changed 14 years ago by
Attachment: | 7947.patch added |
---|
comment:3 Changed 14 years ago by
Owner: | set to Sa'ar Zac Elias |
---|---|
Status: | confirmed → review |
comment:4 Changed 14 years ago by
Component: | General → UI : Dialogs |
---|---|
Status: | review → review_passed |
It's ok, thought negative length is explicitly defined as valid for CSS, it's mostly useful in position style only (e.g. left,top) which doesn't affect our current dialog system yet, which could be handled later as special cases.
comment:5 Changed 14 years ago by
Milestone: | → CKEditor 3.6.1 |
---|
comment:6 Changed 14 years ago by
Resolution: | → fixed |
---|---|
Status: | review_passed → closed |
Fixed with [6994].
True from rev [6979]