Opened 9 years ago

Closed 8 years ago

Last modified 8 years ago

#7983 closed Task (fixed)

Langtool compatible with GNU gettext format

Reported by: Garry Yao Owned by: Garry Yao
Priority: Normal Milestone:
Component: Project : CKLangTool Version:
Keywords: Cc:

Description

Enable the langtool to emit PO files instead of JS files.

Attachments (2)

7983.patch (10.4 KB) - added by Garry Yao 9 years ago.
7983_2.patch (10.5 KB) - added by Garry Yao 9 years ago.

Download all attachments as: .zip

Change History (7)

Changed 9 years ago by Garry Yao

Attachment: 7983.patch added

Changed 9 years ago by Garry Yao

Attachment: 7983_2.patch added

comment:1 Changed 9 years ago by Garry Yao

Owner: set to Garry Yao
Status: newreview

The second patch resolves missing entries from js language files instead of based on equivalence comparison with source language file.

comment:2 Changed 9 years ago by Wiktor Walc

I did not check it yet completely, but there's already one thing that I do not agree with.

I'd definitely avoid deleting directory without asking for confirmation. Even if there is one chance in a million that someone will pass the wrong destination directory, someone will finally do it and will be very unhappy ;-)

Let's simply stop the execution when destination directory exists. If anyone wants to delete the destination directory automatically, he can do this in a batch script.

comment:3 Changed 9 years ago by Garry Yao

Ok...just guess the language output directory always requires frequent updates, so let's leave it to bash/shell.

comment:4 Changed 8 years ago by Wiktor Walc

Resolution: fixed
Status: reviewclosed

I've committed Garry's patch with few enhancements with [7081].

comment:5 Changed 8 years ago by Garry Yao

Committed [7083] to allow update language folder from PO translation files.

Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy