Opened 10 years ago

Closed 9 years ago

#822 closed New Feature (fixed)

Add <th> tag support

Reported by: acmoll@… Owned by: Alfonso Martínez de Lizarrondo
Priority: Normal Milestone: FCKeditor 2.6.4
Component: General Version:
Keywords: SF Confirmed Review+ Cc: Alfonso Martínez de Lizarrondo, liane@…, bngobngo@…, carstanje@…, balliano@…

Attachments (3)

822.patch (37.9 KB) - added by Martin Kou 10 years ago.
822_1.patch (39.1 KB) - added by Alfonso Martínez de Lizarrondo 9 years ago.
Revised patch
822_2.patch (40.2 KB) - added by Alfonso Martínez de Lizarrondo 9 years ago.
Revised patch

Download all attachments as: .zip

Change History (18)

comment:1 Changed 10 years ago by Martin Kou

Cc: Alfonso Martínez de Lizarrondo liane@… bngobngo@… carstanje@… balliano@… added
Description: modified (diff)
Reporter: changed from Martin Kou to acmoll@…

https://sourceforge.net/support/tracker.php?aid=1435863 https://sourceforge.net/support/tracker.php?aid=1166727 https://sourceforge.net/support/tracker.php?aid=1079985 https://sourceforge.net/support/tracker.php?aid=1078586 have been marked as duplicate of this one.


Moved from SF. Original poster: alfonsoml

I add my vote to this feature request, I miss it big time!!!


Moved from SF. Original poster: liane

Me to want this. Please include it in the Table Property dialog box.


Moved from SF. Original poster: bngobngo

This would be great! This way you can control a table better with CSS. The user will see the right format directly when creating a new table.


Moved from SF. Original poster: carstanje

I think this would be a great addition to the editor..

also if this is going to be implemented im guessing the scope attribute would be added as well..

Also may i suggest that <thead>, <tbody> and <tfoot> alos be implemented..

Excellent Work

Leevi Graham


Moved from SF. Original poster: Anonymous

Hi folks, I also think this feature is very important to generate accessible HTML, w3c requires a correct usage of the td/th so I think fck need it.

fabrizio


Moved from SF. Original poster: balliano

comment:2 Changed 10 years ago by Frederico Caldeira Knabben

#1024 has been marked as a DUP.

comment:3 Changed 10 years ago by Frederico Caldeira Knabben

Milestone: FCKeditor 2.6

comment:4 Changed 10 years ago by Wojciech Olchawa

Keywords: Confirmed added

comment:5 Changed 10 years ago by Martin Kou

Owner: set to Martin Kou
Status: newassigned

Changed 10 years ago by Martin Kou

Attachment: 822.patch added

comment:6 Changed 10 years ago by Martin Kou

Keywords: Review? added

comment:7 Changed 10 years ago by Alfonso Martínez de Lizarrondo

Keywords: Review- added; Review? removed

An old patch is available here, (just to check that the new one does cover all the things outlined there): http://sourceforge.net/tracker/index.php?func=detail&aid=1283047&group_id=75348&atid=543655

You should wrap that code in a renameNode function like it was suggested here: http://sourceforge.net/tracker/index.php?func=detail&aid=1409217&group_id=75348&atid=543655 so it can be reused for changing all the cells in a row or column like proposed here: http://sourceforge.net/tracker/index.php?func=detail&aid=1409409&group_id=75348&atid=543655

comment:8 Changed 10 years ago by Frederico Caldeira Knabben

Milestone: FCKeditor 2.6FCKeditor 2.7

All table related tickets have been retargeted to the 2.7. This one was missing.

comment:9 Changed 9 years ago by Martin Kou

Owner: Martin Kou deleted
Status: assignednew

comment:10 Changed 9 years ago by Martin Kou

Milestone: CKEditor 3.0

Changed 9 years ago by Alfonso Martínez de Lizarrondo

Attachment: 822_1.patch added

Revised patch

comment:11 Changed 9 years ago by Alfonso Martínez de Lizarrondo

Keywords: Review? added; Review- removed
Milestone: CKEditor 3.0
Owner: set to Alfonso Martínez de Lizarrondo
Status: newassigned

I've adjusted the previous patch, fixing a bug that compared a function to a string and adding a little fix in the cell selection logic to take TH into account.

comment:12 Changed 9 years ago by Alfonso Martínez de Lizarrondo

again, I forgot the what's new:

		<li>[<a target="_blank" href="http://dev.fckeditor.net/ticket/822">#822</a>] The table cell
			dialog allows to switch between normal data cells or header cells (TD vs TH). </li>

Changed 9 years ago by Alfonso Martínez de Lizarrondo

Attachment: 822_2.patch added

Revised patch

comment:13 Changed 9 years ago by Alfonso Martínez de Lizarrondo

I've added a new patch to include the what's new and the empty style problem mentioned by Shri46 in http://www.fckeditor.net/forums/viewtopic.php?f=11&t=10726&p=28794#p28791

comment:14 Changed 9 years ago by Martin Kou

Keywords: Review+ added; Review? removed

comment:15 Changed 9 years ago by Alfonso Martínez de Lizarrondo

Milestone: FCKeditor 2.6.4
Resolution: fixed
Status: assignedclosed

Fixed with [2363]

Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy